Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting / DepositAll do not work with barrels #40

Closed
ghost opened this issue Jan 23, 2021 · 6 comments
Closed

Sorting / DepositAll do not work with barrels #40

ghost opened this issue Jan 23, 2021 · 6 comments

Comments

@ghost
Copy link

ghost commented Jan 23, 2021

When using barrels in out storage room the following features do not work:

  • Auto sorting of the barrel's inventory
  • /DepositAll

But these work for chests in the same room.
Also tried to use the plugin with a barrel in the middle of nowhere in case something in the room specifically was causing the bug, and ran into the same issues.

However, the following still works with barrels:

  • Left Shift + Left Click to specifically target one barrel and deposit matching items in it
@RoboMWM
Copy link
Member

RoboMWM commented Jan 23, 2021

What /version AutomaticInventory are you running, apparently this has been addressed over a year ago. #20

And in that case it did seem to be supporting /depositall so not sure what changed.

@ghost
Copy link
Author

ghost commented Jan 23, 2021

I'm running 2.12.2 of the plugin which should be the latest (grabbed from https://dev.bukkit.org/projects/automatic-inventory/files) That's also the only plugin on our server.

The server is running "CraftBukkit version 2992-Spigot-018b9a0-b5eb2f5 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)" and it tells me I am 3 versions behind when I use /version on the server. I'm assuming this wouldn't cause issues but maybe I'm wrong?

@RoboMWM
Copy link
Member

RoboMWM commented Jan 23, 2021

Weird. Guess I'll check what barrels are...

@RoboMWM
Copy link
Member

RoboMWM commented Jan 23, 2021

Yea, barrels are included everywhere in the code. You tested with the same scenarios for a chest? Because I think the block's inventory needs to have some of the same items in order to be deposited into it.

@RoboMWM
Copy link
Member

RoboMWM commented Jan 23, 2021

Ok, I may have found the reason for not autosorting but idk if this is used for /depositall Ok it is.

@ghost
Copy link
Author

ghost commented Jan 23, 2021

Yea, barrels are included everywhere in the code. You tested with the same scenarios for a chest? Because I think the block's inventory needs to have some of the same items in order to be deposited into it.

I know you closed it already and appear to have found the reasons behind it (awesome), for the sake of clarity I just wanted to say that I did test with 32 dirt already present in the barrel and 32 on me. This scenario worked with chests in the same room.
Thanks for looking into this by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant