Enhance the speed of whitenoise; #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it appears we are wasting too many samples because k is discontinuous
ufunc.reduce doesn't always work as it doesn't really broadcast the input elements. It tries to build an array out of it.
This is a quick hack to speed up whitenoise filling.
rainwoodman
added a commit
to rainwoodman/nbodykit
that referenced
this pull request
May 26, 2018
The non-transposed PM object is way faster than the transposed PM object in filling gaussian fields. O(Nmesh) vs O(Nmesh^2 / Np**0.5) This depends on MP-Gadget/pmesh#33
rainwoodman
added a commit
to rainwoodman/nbodykit
that referenced
this pull request
May 30, 2018
The non-transposed PM object is way faster than the transposed PM object in filling gaussian fields. O(Nmesh) vs O(Nmesh^2 / Np**0.5) This depends on MP-Gadget/pmesh#33
rainwoodman
added a commit
to rainwoodman/nbodykit
that referenced
this pull request
Jun 1, 2018
The non-transposed PM object is way faster than the transposed PM object in filling gaussian fields. O(Nmesh) vs O(Nmesh^2 / Np**0.5) This depends on MP-Gadget/pmesh#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skips the negative portion of the modes if not requested
adds support non-transposed transforms, which are very efficient for the whitenoise module in 3d, due to continuity in the z axis.
Some clean up is needed before this goes into master. A few printf lines in _whitenoise_generics.h