refactor: move weaving elec_pppm to textile wellknown. #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjousse
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
LGTM 👍 Maybe we should remove it from the export too? https://github.com/MTES-MCT/ecobalyse/blob/master/data/textile/export.py#L113
vjousse
pushed a commit
that referenced
this pull request
Dec 5, 2024
## [2.7.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.6.0..v2.7.0) (2024-12-04) ### 🚀 Features - *(objects)* Introduce components for objects and veli ([#825](#825)) - *(textile)* Update number of references index thresholds. ([#839](#839)) - Introduce objects/veli components db and explorer ([#841](#841)) ### 🚜 Refactor - Move weaving elec_pppm to textile wellknown. ([#843](#843)) ### ⚙️ Miscellaneous Tasks - *(data)* New ingredients ([#814](#814)) - *(data)* Add irrigation to the Ecoinvent organic cotton ([#832](#832)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
This patch is part of this notion card
The
elec_pppmfield in textileprocesses.jsonfile is used by only one process: Weaving. There's no point keeping it in the process datasource. Also and most importantly, this will help having a single format to express processes for all domains eventually.🍰 Solution
Move the weaving pick-per-meter consumption value to some static value in
Data.Textile.WellKnown.🏝️ How to test
Ensure everything keeps working as previously, but api and unit tests should get us pretty much covered.