refactor: move weaving elec_pppm to textile wellknown. #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
This patch is part of this notion card
The
elec_pppm
field in textileprocesses.json
file is used by only one process: Weaving. There's no point keeping it in the process datasource. Also and most importantly, this will help having a single format to express processes for all domains eventually.🍰 Solution
Move the weaving pick-per-meter consumption value to some static value in
Data.Textile.WellKnown
.🏝️ How to test
Ensure everything keeps working as previously, but api and unit tests should get us pretty much covered.