Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aperiodic monotiles to landing page #543

Merged
merged 36 commits into from
Jan 4, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Oct 16, 2023

A fresh and interactive landing page look for the next releases (starting with 1.9.0 #546 #561 ) using the newly found aperiodic monotiles, see the official web page and the repo with the BSD3-licensed code.

image

Different colors (which I prefer as the overall tone is more balanced):

image

Issues

  • Matrix multiplication is implemented in JS, that's why it is a bit slow. Try to hit Reset, then 2x "Monotile". The pattern will then not fill up the whole screen but is far more responsive. We could also have it initialized this way...
    image

  • On tablets, we cannot scroll the website anymore as the dragging of the canvas is somehow taking precedence.

  • I've changed one color to red. If you don't like it, we can change it back to grey as it is here.

@Splines Splines self-assigned this Oct 16, 2023
@Splines Splines mentioned this pull request Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bccb52) 66.48% compared to head (ee76cd9) 66.51%.
Report is 31 commits behind head on mampf-next.

❗ Current head ee76cd9 differs from pull request most recent head 9723468. Consider uploading reports for the commit 9723468 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           mampf-next     #543      +/-   ##
==============================================
+ Coverage       66.48%   66.51%   +0.03%     
==============================================
  Files             311      311              
  Lines            9417     9423       +6     
==============================================
+ Hits             6261     6268       +7     
+ Misses           3156     3155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines mentioned this pull request Oct 22, 2023
@Splines
Copy link
Member Author

Splines commented Oct 25, 2023

@fosterfarrell9 I've added the aperiodic monotiles (ein stein) as interactive background. Currently available on experimental for you to try out. More infos in the PR.

@Splines Splines changed the title Add new landing page background image Add aperiodic monotiles to landing page Oct 25, 2023
@fosterfarrell9
Copy link
Collaborator

fosterfarrell9 commented Oct 26, 2023

Is it possible to make the tiles bigger? I think that the current size makes it look a little restless/"unruhig".
(I have shown it to several people. Another suggestion was to reduce the opacity for the tile image a bit).

@Splines
Copy link
Member Author

Splines commented Oct 27, 2023

@fosterfarrell9 I've made the tiles bigger and darkened the colors to make the background less busy/jarring. Due to the bigger tiles, the numer of tiles generated are reduced which also makes the page run more smoothly.
I've also fixed the issue on mobile devices, it should work on all devices now (buttons are disabled on small devices and you cannot drag the background, otherwise one could not scroll the site anymore). I've also implemented a small logic to disable the "monotile" button as to not freeze browsers when generating too many tiles.

image

image

fosterfarrell9
fosterfarrell9 previously approved these changes Nov 1, 2023
@Splines Splines mentioned this pull request Jan 3, 2024
1 task
@Splines Splines marked this pull request as ready for review January 3, 2024 15:14
@Splines Splines requested a review from fosterfarrell9 January 3, 2024 15:15
@Splines
Copy link
Member Author

Splines commented Jan 3, 2024

@fosterfarrell9 Requesting a review just for the last two commits where I merged the lint/eslint-all branch into this branch. You probably want to review #575 first (e.g. maybe some rules will change due to your review and then we'd have to update here accordingly).

Note that this branch currently has commits from #575 on it. These will go away, once we've merged #575 into mampf-next.

@Splines Splines merged commit b88b79e into mampf-next Jan 4, 2024
3 checks passed
@Splines Splines deleted the feature/login-background-image branch January 4, 2024 21:47
Splines added a commit that referenced this pull request Jan 6, 2024
* Replace background image

* Add slight transparency to boxes on landing page

* Recolor github badge (yellow)

* Add interactive aperiodic monotile to landing page

* Fix dragging of canvas

* Fix canvas dragging & z-index

* Add find out more button

* Add copyright notice for aperiodic monotiles

* Move to assets/javascript folder

* Fix turbolinks setup

* Make buttons less obtrusive

* Fix P5.js initialization

* Change to less obtrusive grey color

* Make colors darker & delete unused comment

* Adjust scaling and add black overlay

* Disable buttons according to their state

* Add touchMoved function

* Disable buttons on small devices

* Remove console log

* Make grey color lighter

* Fix JS layout (according to new ESLint rules)

* Add cypress rules to ESLint & ignore some patterns

* Allow usage of tempusDominus global variable

* Ignore JS files with Sprocket syntax

* Further improve rules, e.g. allow common globals

* Ignore sprocket syntax in cable.js

* Autofix all `.js` and `.js.erb` files

Command used:
`yarn run eslint --fix .`

Still 47 problems (27 errors, 20 warnings) after this.

* Fix variables in turbolink fix

* Prepend unused variables with "_"

* Get rid of unused widget variable

* Fix specs comment tab alignment

* Disable some ESLint rules for monotile code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants