-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aperiodic monotiles to landing page #543
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mampf-next #543 +/- ##
==============================================
+ Coverage 66.48% 66.51% +0.03%
==============================================
Files 311 311
Lines 9417 9423 +6
==============================================
+ Hits 6261 6268 +7
+ Misses 3156 3155 -1 ☔ View full report in Codecov by Sentry. |
@fosterfarrell9 I've added the aperiodic monotiles (ein stein) as interactive background. Currently available on experimental for you to try out. More infos in the PR. |
Is it possible to make the tiles bigger? I think that the current size makes it look a little restless/"unruhig". |
@fosterfarrell9 I've made the tiles bigger and darkened the colors to make the background less busy/jarring. Due to the bigger tiles, the numer of tiles generated are reduced which also makes the page run more smoothly. |
Command used: `yarn run eslint --fix .` Still 47 problems (27 errors, 20 warnings) after this.
@fosterfarrell9 Requesting a review just for the last two commits where I merged the Note that this branch currently has commits from #575 on it. These will go away, once we've merged #575 into |
* Replace background image * Add slight transparency to boxes on landing page * Recolor github badge (yellow) * Add interactive aperiodic monotile to landing page * Fix dragging of canvas * Fix canvas dragging & z-index * Add find out more button * Add copyright notice for aperiodic monotiles * Move to assets/javascript folder * Fix turbolinks setup * Make buttons less obtrusive * Fix P5.js initialization * Change to less obtrusive grey color * Make colors darker & delete unused comment * Adjust scaling and add black overlay * Disable buttons according to their state * Add touchMoved function * Disable buttons on small devices * Remove console log * Make grey color lighter * Fix JS layout (according to new ESLint rules) * Add cypress rules to ESLint & ignore some patterns * Allow usage of tempusDominus global variable * Ignore JS files with Sprocket syntax * Further improve rules, e.g. allow common globals * Ignore sprocket syntax in cable.js * Autofix all `.js` and `.js.erb` files Command used: `yarn run eslint --fix .` Still 47 problems (27 errors, 20 warnings) after this. * Fix variables in turbolink fix * Prepend unused variables with "_" * Get rid of unused widget variable * Fix specs comment tab alignment * Disable some ESLint rules for monotile code
A fresh and interactive landing page look for the next releases (starting with 1.9.0
#546#561 ) using the newly found aperiodic monotiles, see the official web page and the repo with the BSD3-licensed code.Different colors (which I prefer as the overall tone is more balanced):
Issues
Matrix multiplication is implemented in JS, that's why it is a bit slow. Try to hit Reset, then 2x "Monotile". The pattern will then not fill up the whole screen but is far more responsive. We could also have it initialized this way...
On tablets, we cannot scroll the website anymore as the dragging of the canvas is somehow taking precedence.
I've changed one color to red. If you don't like it, we can change it back to grey as it is here.