Code copied without retaining authorship information

[olejandro]

@energynumbers @daly-h it seems that the large parts of the original code from energy charts have been included directly in this app. In this process, among other things, authorship information was not preserved. I encourage you to correct this omission and include it as devependency instead.

[energynumbers]

I'm very much looking forward to being able to include it as a dependency. I haven't been able to get the new energy-charts to build in a form that behaves when imported as a dependency into this package yet. Indeed, even the linking of the app's own js and css induced a devilish little bug, when using deep linking. In the end, the fix (adding base: '/', to vite.config.js) was simple, but wow finding that fix was hard.

I expect I will be able to get it working as a separate package at some point. At that point, I'll be including it as a dependency on the MaREI-EPMG/energy-charts github repository, so that we can continue to use our own customised version of your very useful software. However, right now, it's only used in two places, so I'm pretty comfortable with it being embedded, rather than a standalone package, for now. If we end up with it in more than two places, then making it work as a dependency will become a priority. Making it work at all with the download-data button and the deep-linking has been the #1 priority for this round.

I'll bring over the README.md from the energy-charts package into the energy-charts subdir here, and add a comment to each file that I've customised.

[olejandro]

Thank you @energynumbers. Making sure there is no confusion regarding the authorship should be your number one priority, since this is a public repository.

Tbh, I am also very surprised how you've approached including the customised version of energy-charts in epmg-energy-scenarios. I am sure it would have been much more straight forward (as well as causing fewer questions from my side) to do it as a git submodule or git subtree.

As always, you are very welcome to reach out if you have any questions regarding energy-charts or epmg-energy-scenarios. I understand it is not always very easy to work with the tools that someone else has thought up, designed and developed.

[olejandro]

@energynumbers thanks for moving on to addressing this issue promptly. I would have really appreciated being given the to chance comment on / approve the changes though. I will open a PR correcting some of the changes.

[olejandro]

@energynumbers I've looked through the most recent changes and I don't believe that "contains EPMG customisations" is compliant with the terms of the license, because the changes that EPMG introduced are not easily identifiable. To make this right you should include the energy-charts version you based your changes on as a subtree and then apply your changes on top of it. Alternatively you can include your customised fork as a subtree. Let me know if you need any help with this. I don't think it is in anybody's interest for this to be in violation of the license.