Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug "Serial" object use in the library can cause issues with small platforms that don't have it. #856

Open
Makuna opened this issue Oct 28, 2024 · 1 comment
Labels

Comments

@Makuna
Copy link
Owner

Makuna commented Oct 28, 2024

Describe the bug
Some platforms don't expose a Serial object. This can cause compiler issues due to debug methods present in the library.
An example is the method SerialDumpTables in \colors\NeoGammaDynamicTableMethod.h

To Reproduce

Expected behavior

Development environment (please complete the following information):

  • OS: [e.g. Win10]
  • Build Environment [e.g. Arduino IDE v.1.8.10]
  • Board target [e.g. AVR Mege 2560, v 1.10.31 ] - you will need to check the board manager for this.
  • Library version [e.g. v2.3.4] - you will need to check the library manager for this. If you used github to clone it, mention this and include the reference.

Additional context
Either wrap in a debug define or change the method to a template method where the object and object type can be provided.

@Makuna Makuna added the bug label Oct 28, 2024
@sparkplug23
Copy link

OS: Windows 11
Build Environment: Arduino IDE 2.3.2
Board target: ATTiny85.
Library version: 2.9.1 CoreShader Branch

#if !(defined(ARDUINO_ARCH_AVR) || defined(ARDUINO_ARCH_MEGAAVR))
    static void SerialDumpTables()
    {
        // Function
    }
#endif

This enables the code to compile correctly for ATTiny85, have not yet tested other target boards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants