Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use config.load_defaults for rails 7 with overrides #23176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use config.load_defaults for rails 7 with overrides #23176

wants to merge 2 commits into from

Commits on Sep 20, 2024

  1. Use config.load_defaults for rails 7 with overrides 

    https://github.com/rails/rails/blob/d437ae311f1b9dc40b442e40eb602e020cec4e49/railties/lib/rails/application/configuration.rb#L92
* belongs_to_required_by_default must be overridden or seeding fails
* Partial inserts cause test failures in ui-classic, content, and amazon provider
* Need to investigate the X-XSS-Protection change before using default of disabling it
* Allow deprecations to be found and fixed

Fixes ManageIQ#23172
    @jrafanie
    jrafanie committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f7395d4 View commit details
    Browse the repository at this point in the history

  2. Disable x-xss-protection as it's the defaults now 

    Both rails and secure header are now shipping with 0 by default.

See: https://www.github.com/github/secure_headers/issues/439
    @jrafanie
    jrafanie committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a393d4a View commit details
    Browse the repository at this point in the history