Use the rails 7.1+ serialize interface #23253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
added a commit
to jrafanie/manageiq-consumption
that referenced
this pull request
Nov 1, 2024
Type was changed from positional to a keyword argument 'type' in 7.1. The positional argument is removed in rails 7.2. We have a helper bridge module prepending support for either kwargs or positional arguments passed to serialize which converts to positional for rails 7.0 and kwargs for 7.1+. This was added and automatically loaded in the rails app via the engine in schema: ManageIQ/manageiq-schema#756 Similar change as core: ManageIQ/manageiq#23253
Fryguy
approved these changes
Nov 1, 2024
This was referenced Nov 1, 2024
|
Ok, it's failing on a real issue...will mark as wip... interestingly service_mixin referencing service to ensure an object can't be associated with more than one service... note, service is an alias_attribute of parent... this is one of the "problems" in rails 7.1 as alias_attribute doesn't support non-attributes such as parent (an association). |
jrafanie
changed the title
|
Think these are legit / not too hard to fix: assuming it is because a different exception is raised |
Type was changed from positional to a keyword argument 'type' in 7.1. The positional argument is removed in rails 7.2. We have a helper bridge module prepending support for either kwargs or positional arguments passed to serialize which converts to positional for rails 7.0 and kwargs for 7.1+. This was added and automatically loaded in the rails app via the engine in schema: ManageIQ/manageiq-schema#756
jrafanie
force-pushed
the
serialize-with-kwargs-like-71-wants
branch
from
96a76f6
to
5cec895
Compare
jrafanie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type was changed from positional to a keyword argument 'type' in 7.1. The positional argument is removed in rails 7.2.
We have a helper bridge module prepending support for either kwargs or positional arguments passed to serialize which converts to positional for rails 7.0 and kwargs for 7.1+. This was added and automatically loaded in the rails app via the engine in schema:
ManageIQ/manageiq-schema#756
Extracted from #23225