[FEATURE] Even Quicker Rolling (by Default)

[maxobremer]

Is your feature request related to a problem? Please describe.
With the new v4 version the modules works well with the new activities. But weapons/items with multiple activities can still be a tad slower then desired even with quick rolls enabled. To skip the choose activity dialogue foundry uses the shift key, the same key that RSR uses for disadvantage.

Describe the solution you'd like
Here are a couple of solutions:

• Have an option to disable the advantage/disadvantage rolling shortcuts all together (frankly I dont use them at all)
• Move the advantage/disadvantage rolling shortcuts to the Configure Controls menu, rather then the Configure Settings menu (or dont bother with it as an option and let DnD5e set up the shortcuts (see image) and add your own configurable buttons in a new RSR section for bypassing quick rolls and skipping activity dialogues
  
• Have the Alt key do double duty. If held on an item it fasts forward the choose activity dialogue and quick rolls the item, if held when clicking on an activity it bypasses the quick roll for the activity
• A setting to always use the default activity unless bypassed with alt or another configurable key is held (people can open up the item description for other activities)

Describe alternatives you've considered
For maybe like 0.1 second I had considered not using this module, maybe if the dnd5e team works this in/takes some usage of RSR and puts it in the base system.

Additional context
Well done so far.

[MangoFVTT]

I am aware of this overlap and mismatch between the default dnd5e controls and the RSR modifiers. It's a bit tricky to solve, because I don't really have a way to hook into the "shift-click to skip" part of the activity, and can only start interacting with things AFTER that dialog already happens. At some point I think it will make sense for RSR to switch to using the default dnd5e controls, but that is not as trivial as it may appear and will require some changes to the advantage/disadvantage generation. Fortunately it has been made easier by the removal of alternate rolls, so I will be able to look into it soon-ish

[maxobremer]

All good, its a feature request not a bug report, so am not assuming it will be 'fixed' soon. Just bringing up things I notice while testing RSR in a v4 environment

[MangoFVTT]

Turns it was easier than I thought to switch RSR to using the default dnd5e controls, so I did that. This still does not fix the "shift+click to skip activity dialog" problem, but at least now (from next release) RSR will use the exact same key modifiers as the core system, which is a step closer to unifying controls between the two.

[maxobremer]

Well shift does already skip the activity dialogue (it just also rolled with disadvantage due to RSR)
What I am more interested is is what button to use to bypass the quick roll for those that want use the roll dialogue and shit

[maxobremer]

Did not read the latest patch notes, but will checl out how it works/feels in use when i get home.

Well done in the quick work btw

[MangoFVTT]

@maxobremer as of the latest update, you can do the following with RSR:

• Use whatever modifiers you add into the dnd5e controls for "Advantage" & "Disadvantage" to roll a quick roll with Advantage or Disadvantage. This is pretty much the exact behaviour as vanilla, except it uses RSR styling.
• Use whatever modifier you add into the dnd5e controls for "Skip Dialog" to NOT skip dialog (i.e. to not quick roll and get the usual roll dialogs). I know it's a bit counterintuitive, but think of it as RSR essentially swapping the fast forward behaviour to be the reverse of the vanilla system, while keeping the same modifier keys.

The upside of these changes are that you can customise your keys as you wish and avoid any overlapping behaviour with the core system.

[maxobremer]

Looks good so far. The possiblity of an option to have shift NOT bypass quick rolls on items but still bypass on activities would be nice in the future but not that necessary as people can just open up the description and click the attack activity there if they want to make multiple attacks from a weapon/item with multiple activities. Just a thought for future development to give people more options in using this module.

Again, well done with the rapid development and updates these past few days

[MangoFVTT]

@maxobremer for some reason, the "Shift + Click to Skip Activity Dialog" is fully hard-coded into the dnd5e system and does NOT use the key modifiers from the controls. It always remains "Shift+Click" no matter what you change, which is annoying. I assume this is an oversight and will bring it up on the core system to at least get it to align with the controls and avoid any clash with RSR controls. I'm also trying to petition for a hook there that allows the fast forwarding of the dialog without needing to hold a key so RSR can do its thing

[RalphTheBard]

@MangoFVTT after your latest 4.1 compat fix, I'm curious how advantage is invoked. Disabling/enabling the Skip Dialog controls doesn't seem to change the current function (which rolls a single die). Is this functionality dependent on this github feature being addressed?
Update: Confirmed works as per Mango's instruction below.

[MangoFVTT]

@RalphTheBard you can invoke advantage for any quick roll by holding the Skip Dialog with Advantage button you've set in your dnd5e keybindings, same for disadvantage