Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 Improve "This action will have no effect" error message #439

Open
MarcusOtter opened this issue Jun 4, 2023 · 0 comments
Open

💡 Improve "This action will have no effect" error message #439

MarcusOtter opened this issue Jun 4, 2023 · 0 comments
Labels
improvement 💡 Improvement suggestion

Comments

@MarcusOtter
Copy link
Owner

Describe the improvement

Can occur in many places, but it's not very clear what it means sometimes.

For example, I just had it occur when people were pressing the "Close" button. Turns out the threads were already set to 1 hour hide time, and they had the "archive in 1 hour" setting on their close command.

We should add some more context to this error message.

Problems this improvement solves

Unclear error messages can be very frustrating, and sometimes it can even take me a while to decipher them as well. I had to look up the config and join the server to try it out for myself.

Alternative solutions

I thought about unique error messages for these cases (like, "This is already the config" or "This thread is already closed") but this will mean that we have a lot of error messages which is harder to translate and also is less generalizable in the code.

@MarcusOtter MarcusOtter added the improvement 💡 Improvement suggestion label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement 💡 Improvement suggestion
Projects
None yet
Development

No branches or pull requests

1 participant