Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show static leases (PR welcome?) #41

Open
boretom opened this issue Jan 29, 2024 · 2 comments
Open

Show static leases (PR welcome?) #41

boretom opened this issue Jan 29, 2024 · 2 comments

Comments

@boretom
Copy link

boretom commented Jan 29, 2024

Hi,

I got into VyOS and versions < 1.5 use this module to get the DHCP leases, well all except the static one since they are in the dhcp.conf file.

Would there be an interest to list the static leases to in this module? And maybe accepting a PR if someone (me :) ) would create one?

Or is it out of the scope/interest of this module?

Have a great day
Thomas

@MartijnBraam
Copy link
Owner

Oh that's an interesting usecase I haven't thought of. I think it makes sense to have support for reading those from this module but I don't think it should be integrated in the dhcp.leases parser.

I think a seperate class that can parse the static leases from the config file (and maybe more in the future) would make sense so the behavior of the current class stays the same and the static leases contain different information than the information stored in the leases file and there's some wildcard possibilities from scanning the specs for this quickly.

@boretom
Copy link
Author

boretom commented Feb 5, 2024

In another modules of course, as you correctly stated there are different information associated with the static leases. Something like dhcp.leases_static (I'm not that much of a progammer, have to check what the naming conventions are).

Let's me think about it :) ... but good to know that you would be open to add that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants