-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to add email verification #612
Comments
For reference, Laravel have a great DX for this: https://laravel.com/docs/9.x/verification I may take a crack at starting a PR next week for this, useful for what we're working on. |
Thanks. I don't like the way we did it in 3.0 which is why I never brought that feature over to 4.x |
What didn't you like about your previous implementation? Useful to keep the lessons learned, if you don't mind sharing. |
I think we had like email sending inside the model, verifying was done against the model when it prob should have been done in a middleware. I don't remember exactly how it was done but I didn't really like it. Just very clunky. Most of the logic was done inside the scaffolded controllers which prevents us from updating any issues, etc. We'll have to flesh this idea out a bit and detail each step of the flow to make sure this works for M4. |
Thanks for that. I've just implemented and deployed email verification today so can provide a high level overview of what I did:
|
Is your feature request related to a problem?
No
What do we currently have to do now?
No response
Describe the solution you'd like
MustVerifyEmail class add to User model, Email Verification Template and Middleware
Describe alternatives you've considered
No response
Would this be a breaking change ?
Anything else ?
No response
The text was updated successfully, but these errors were encountered: