Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0 #6

Closed
wants to merge 78 commits into from
Closed

3.0 #6

wants to merge 78 commits into from

Conversation

girardinsamuel
Copy link

@girardinsamuel girardinsamuel commented Oct 18, 2020 •
edited
Loading

⚠️ This refactoring will be integrated directly into Masonite 4 core !. This repo won't be used anymore from Masonite 4.

Refactoring

  • migration to Masonite 3
  • usual package refactoring as in other repos (github actions, badges on readme etc ...)
  • architecture refactoring

New features

  • Add a new database driver to save notifications in database
  • Add a new broadcast driver to broadcast notifications
  • Add a new vonage driver with Vonage(Nexmo) SMS service => after this one all others will be in external packages.
  • Add a Notifiable mixin to set app models notifiable (such as User).
  • Update the mail and slack driver to be more flexible
  • Drop attachments in favor of blocks for Slack notif creation (as attachments will be deprecated)
  • Add a way to send notifications to not Notifiable entity aka AnonymousUsers
  • Add a way to ignore_errors when sending
  • Refactor dry to send notifications without actually sending
  • Add unit tests for core features and all drivers
  • Add Custom notification class creation and use as any drivers
  • Add channels override on the fly
  • Add Event handling with masonite-events => in an other PR later

Documentation

has been entirely rewritten and available MasoniteFramework/docs#131

Fixes #2
Fixes #1

@girardinsamuel girardinsamuel mentioned this pull request Oct 18, 2020
Closed
@girardinsamuel girardinsamuel mentioned this pull request Oct 24, 2020
Open
@girardinsamuel girardinsamuel mentioned this pull request Oct 25, 2020
Closed
@girardinsamuel girardinsamuel changed the title Rewrite the package to add more flexibility 3.0 Oct 25, 2020
@josephmancuso
Copy link
Member

@girardinsamuel looks like this needs to be updated for Masonite ORM? I see orator issues in the tests

@girardinsamuel
Copy link
Author

Yeah I have to migrate to Masonite ORM, and test a bit the features.

Also I need to continue updating documentation in the related PR.

@josephmancuso
Copy link
Member

Ok awesome. I discovered a way to see all pull requests in an organization lol. So I found this one from October of 2020 .. lol.

https://github.com/pulls

Can add whatever filters you need in the filter bar

@girardinsamuel
Copy link
Author

girardinsamuel commented Jan 24, 2021 •
edited
Loading

@josephmancuso I have completed to refactor this package for 3.0 and to add features.

  • I have updated nearly all masonite notifications documentation (just have to document broadcasting notifications)
  • I have tested the different notifications channels and the general behaviour on a local project

It was a big work, hope you'll like this 💪 🚀

Maybe after releasing this we should integrate this package into Masonite core, this should be quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Nexmo comonent for text messaging add a DatabaseComponent
2 participants
@girardinsamuel @josephmancuso