Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site.rst for HTCondor Batch system adapter #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SaidevPolisetty
Copy link

Description about the "TardisDroneUuid" requirement incase of a change in the hostname (arbitrary and non-default)

Description about the "TardisDroneUuid" requirement incase of a change in the hostname (arbitrary and non-default)
@SaidevPolisetty SaidevPolisetty changed the title Update site.rst for HTCondor Site adapter Update site.rst for HTCondor Batch system adapter Apr 23, 2024
@giffels giffels requested review from a team, giffels and maxfischer2781 and removed request for a team April 25, 2024 09:57
Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the documentation of TARDIS. However, I think your note should go to the docs/source/adapters/batchsystem.rst instead and in this file in the HTCondor section. In addition, I would prefer to rephrase it, so that it is clear what attribute needs to be added where and what it will change.

Thanks,
Manuel

@giffels
Copy link
Member

giffels commented May 15, 2024

Thanks for your contribution to the documentation of TARDIS. However, I think your note should go to the docs/source/adapters/batchsystem.rst instead and in this file in the HTCondor section. In addition, I would prefer to rephrase it, so that it is clear what attribute needs to be added where and what it will change.

Thanks, Manuel

@SaidevPolisetty is there any progress on that or do you need some help or have questions?

@SaidevPolisetty
Copy link
Author

Thanks for your contribution to the documentation of TARDIS. However, I think your note should go to the docs/source/adapters/batchsystem.rst instead and in this file in the HTCondor section. In addition, I would prefer to rephrase it, so that it is clear what attribute needs to be added where and what it will change.
Thanks, Manuel

@SaidevPolisetty is there any progress on that or do you need some help or have questions?

Yes, sorry, got side tracked with other works. I will update it today

Description about the "TardisDroneUuid" requirement incase of a change in the hostname (arbitrary and non-default)
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (5251da3) to head (a4ac000).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   98.87%   98.92%   +0.04%     
==========================================
  Files          55       55              
  Lines        2225     2226       +1     
==========================================
+ Hits         2200     2202       +2     
+ Misses         25       24       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaidevPolisetty
Copy link
Author

@giffels I have made the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants