-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UnionFileSystem.getBasePaths
public
#61
Comments
What is the functional requirement here? |
|
That is not an argument for making it public. We encapsulate it by default. So unless you have a reason why you want this I am not sure we will do this? |
I'm enumerating the classpath of the game, and I want to get the jars in the classpath. However, if I only have access to the primary path, then some JARs that belong to certain modules are not exposed in the enumerated classpath. A good example of this is Minecraft. Minecraft is made up of three JARs: neoforge, client-extra, and client. |
Enumerating the classpath of the game is a bad idea. Maybe we can provide you with a better API that is suited for your usecase. What are you exactly trying to do? |
I'm trying to give a library that requires the classpath in a list (it can't find it itself because its locator doesn't work with Neo's class loaders) the classpath in a list. |
Please contact me on discord. |
This is incredibly useful for discovering all elements on the classpath. Currently only
getPrimaryPath
is available, which isn't sufficient for UFSes with multiple base paths, such as the Minecraft one (made up of NeoForge, client-extra, and client).The text was updated successfully, but these errors were encountered: