Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCPL_input gives a strange Warning #1733

Closed
ebknudsen opened this issue Oct 10, 2024 · 1 comment
Closed

MCPL_input gives a strange Warning #1733

ebknudsen opened this issue Oct 10, 2024 · 1 comment
Labels
annonyance Does not really count as a full bug... C: McStas component mcstas-3.5.1

Comments

@ebknudsen
Copy link
Contributor

Purely cosmetic, but pretty confusing:

When running 1e6 rays on single node with a single mcpl-file and otherwise only default parameters to MCPL_input, the component reports the following:

analyze_mcpl] Initialize
Message(source): MCPL file (../Scan_Open_MCPL/0/beam_at_pinhole_2.mcpl.gz) produced with mcstas 3.5.2 ODIN.
Message(source): MCPL file (../Scan_Open_MCPL/0/beam_at_pinhole_2.mcpl.gz) contains 4957012 particles.

 WARNING: You have requested a repeat_count=1 but have left all *_smear parameters at 0!
 --> This is not allowed! Resetting to repeat_count=1!

 WARNING: You have requested a repeat_count=1 but have left all *_smear parameters at 0!
 --> This is not allowed! Resetting to repeat_count=1!

 Warning: You are using MCPL_input with a repeat_count of 1:
 - Minimum neutron count requested is 4957012 x 1 <= 4957012 neutrons total

Something seems a bit off with the warning logic here.

@ebknudsen ebknudsen added C: McStas component annonyance Does not really count as a full bug... mcstas-3.5.1 labels Oct 10, 2024
@willend
Copy link
Contributor

willend commented Oct 11, 2024

An if statement here should likely be shifted from

if (repeat_count) ->
if (repeat_count>1)

Thanks for reporting @ebknudsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annonyance Does not really count as a full bug... C: McStas component mcstas-3.5.1
Projects
None yet
Development

No branches or pull requests

2 participants