Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to jdk 21 #1932

Closed
rdenarie opened this issue May 3, 2024 · 4 comments
Closed

Update to jdk 21 #1932

rdenarie opened this issue May 3, 2024 · 4 comments

Comments

@rdenarie
Copy link
Member

rdenarie commented May 3, 2024

JDK 21 is the last available LTS java version.

We should build and run on this version
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this issue May 3, 2024
@rdenarie
fix: Update to jdk21 - EXO-71474
10231b0 
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/meeds#1932
@rdenarie rdenarie mentioned this issue May 3, 2024
Closed
rdenarie added a commit to Meeds-io/gatein-portal that referenced this issue May 3, 2024
@rdenarie
fix: Update to jdk21 - EXO-71522
21ababe 
Before this fix, the simpleDateFormat for locale en is
MM/dd/yyyy, HH:mm:ss a
In jdk17 and under, the space between 'ss' and 'a' is a simple space
In JDK 21, the space was changed to '[NNBSP]a' ([OpenJDK information](https://bugs.openjdk.org/browse/JDK-8324665)) : , so the .contains(" a") returns always false

This commit add the test on '[NNBSP]a' in addition of ' a' in order to make it work on both jdk version

Resolves Meeds-io/meeds#1932
@rdenarie rdenarie mentioned this issue May 3, 2024
Closed
rdenarie added a commit to Meeds-io/gatein-portal that referenced this issue May 3, 2024
@rdenarie
fix: Update to jdk21 - EXO-71522
0350693 
Before this fix, the simpleDateFormat for locale en is
MM/dd/yyyy, HH:mm:ss a
In jdk17 and under, the space between 'ss' and 'a' is a simple space
In JDK 21, the space was changed to '[NNBSP]a' ([OpenJDK information](https://bugs.openjdk.org/browse/JDK-8324665)) : , so the .contains(" a") returns always false

This commit add the test on '[NNBSP]a' in addition of ' a' in order to make it work on both jdk version

It also add surefire configuration to work with jdk21

Resolves Meeds-io/meeds#1932
rdenarie added a commit to Meeds-io/commons that referenced this issue May 3, 2024
@rdenarie
fix: Update to jdk21 - EXO-71522
9916fae 
Adapt coverage ratio

Resolves Meeds-io/meeds#1932
@rdenarie rdenarie mentioned this issue May 3, 2024
Closed
@rdenarie
Copy link
Member Author

rdenarie commented May 3, 2024

Hi @boubaker

I prepare PR to jump to JDK 21.

Once these PRs are merged, build will still work with JDK17.

So, my proposition is :

  • You take a quick look on 3 PRs
  • If no objection, I merge on develop, ask for a release of maven-parent-pom and addon-parent-pom
  • When all PRs are merged, I ask to update jenkins build job and deployment job to be update to use jdk21

rdenarie added a commit to Meeds-io/commons that referenced this issue May 3, 2024
@rdenarie
fix: Update to jdk21 - EXO-71474
42489bd 
Adapt coverage ratio

Resolves Meeds-io/meeds#1932
rdenarie added a commit to Meeds-io/gatein-portal that referenced this issue May 3, 2024
@rdenarie
fix: Update to jdk21 - EXO-71474
daa7e8c 
Before this fix, the simpleDateFormat for locale en is
MM/dd/yyyy, HH:mm:ss a
In jdk17 and under, the space between 'ss' and 'a' is a simple space
In JDK 21, the space was changed to '[NNBSP]a' ([OpenJDK information](https://bugs.openjdk.org/browse/JDK-8324665)) : , so the .contains(" a") returns always false

This commit add the test on '[NNBSP]a' in addition of ' a' in order to make it work on both jdk version

It also add surefire configuration to work with jdk21

Resolves Meeds-io/meeds#1932
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this issue May 3, 2024
@rdenarie
fix: Update to jdk21 - EXO-71474
6c43628 
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/meeds#1932
@boubaker
Copy link
Member

boubaker commented May 3, 2024

Great move, thanks.

@rdenarie there is already an MIP for this Meeds-io/MIPs#91
Can you please use it for initiating the Upgrade switch MIP process

@boubaker
Copy link
Member

boubaker commented May 3, 2024

Besides, I think we should do a deep cleanup to delete the usage of Security Manager in Core Foundation projects, see https://nipafx.dev/road-to-21-upgrade/ for more information about changes to take care of.

@rdenarie
Copy link
Member Author

rdenarie commented May 3, 2024

Close this issue as there is a MIP on it (Meeds-io/MIPs#91)

@rdenarie rdenarie closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boubaker @rdenarie