From f50b209ebfe5cad622fb8cd4d1096edb0d11715c Mon Sep 17 00:00:00 2001 From: Jongsun Suh Date: Fri, 19 Jul 2024 14:03:24 -0400 Subject: [PATCH] Set yarn resolution for `@metamask/snaps-sdk@6.1.0` dependency `@metamask/providers` from `17.0.0` to `17.1.1` --- package.json | 1 + packages/accounts-controller/CHANGELOG.md | 7 ++++++ .../src/AccountsController.ts | 4 ++-- packages/chain-controller/CHANGELOG.md | 7 ++++++ packages/profile-sync-controller/CHANGELOG.md | 7 ++++++ yarn.lock | 23 +------------------ 6 files changed, 25 insertions(+), 24 deletions(-) diff --git a/package.json b/package.json index fadb540dbc..d18e80d83c 100644 --- a/package.json +++ b/package.json @@ -43,6 +43,7 @@ "pre-push": "yarn lint" }, "resolutions": { + "@metamask/snaps-sdk@6.1.0/@metamask/providers": "17.1.1", "tsup@^8.0.2": "patch:tsup@npm%3A8.0.2#./.yarn/patches/tsup-npm-8.0.2-86e40f68a7.patch" }, "devDependencies": { diff --git a/packages/accounts-controller/CHANGELOG.md b/packages/accounts-controller/CHANGELOG.md index bb3606bd4b..bec467408e 100644 --- a/packages/accounts-controller/CHANGELOG.md +++ b/packages/accounts-controller/CHANGELOG.md @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Uncategorized + +- Please hold off on new releases of this package until the yarn resolution for `@metamask/providers` is removed. + - This is blocked by a `@metamask/snaps-sdk` release with `@metamask/providers` bumped to `>=17.1.1`. + - See: [Fix regressions introduced by @metamask/providers@17.1.1](https://github.com/MetaMask/snaps/pull/2579) + - Build error fixed by yarn resolution: [MetaMask/core/actions/runs/10011688901/job/27675682526?pr=3645](https://github.com/MetaMask/core/actions/runs/10011688901/job/27675682526?pr=3645) + ## [17.2.0] ### Added diff --git a/packages/accounts-controller/src/AccountsController.ts b/packages/accounts-controller/src/AccountsController.ts index 77d8a55ad8..ed4e34632c 100644 --- a/packages/accounts-controller/src/AccountsController.ts +++ b/packages/accounts-controller/src/AccountsController.ts @@ -423,8 +423,8 @@ export class AccountsController extends BaseController< ...account, metadata: { ...account.metadata, name: accountName }, }; - // Do not remove this comment: This error is flaky. Comment out and restore the `ts-expect-error` directive below as needed. - // @ts-expect-error Known issue - `Json` causes recursive error in immer `Draft`/`WritableDraft` types + // Do not remove this comment - This error is flaky: Comment out or restore the `ts-expect-error` directive below as needed. + // // @ts-expect-error Known issue - `Json` causes recursive error in immer `Draft`/`WritableDraft` types currentState.internalAccounts.accounts[accountId] = internalAccount; }); } diff --git a/packages/chain-controller/CHANGELOG.md b/packages/chain-controller/CHANGELOG.md index 9faa52486d..c2665a0e74 100644 --- a/packages/chain-controller/CHANGELOG.md +++ b/packages/chain-controller/CHANGELOG.md @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Uncategorized + +- Please hold off on new releases of this package until the yarn resolution for `@metamask/providers` is removed. + - This is blocked by a `@metamask/snaps-sdk` release with `@metamask/providers` bumped to `>=17.1.1`. + - See: [Fix regressions introduced by @metamask/providers@17.1.1](https://github.com/MetaMask/snaps/pull/2579) + - Build error fixed by yarn resolution: [MetaMask/core/actions/runs/10011688901/job/27675682526?pr=3645](https://github.com/MetaMask/core/actions/runs/10011688901/job/27675682526?pr=3645) + ## [0.1.0] ### Changed diff --git a/packages/profile-sync-controller/CHANGELOG.md b/packages/profile-sync-controller/CHANGELOG.md index ab2ad99ed2..e9cc1c654e 100644 --- a/packages/profile-sync-controller/CHANGELOG.md +++ b/packages/profile-sync-controller/CHANGELOG.md @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Uncategorized + +- Please hold off on new releases of this package until the yarn resolution for `@metamask/providers` is removed. + - This is blocked by a `@metamask/snaps-sdk` release with `@metamask/providers` bumped to `>=17.1.1`. + - See: [Fix regressions introduced by @metamask/providers@17.1.1](https://github.com/MetaMask/snaps/pull/2579) + - Build error fixed by yarn resolution: [MetaMask/core/actions/runs/10011688901/job/27675682526?pr=3645](https://github.com/MetaMask/core/actions/runs/10011688901/job/27675682526?pr=3645) + ## [0.1.4] ### Added diff --git a/yarn.lock b/yarn.lock index 21e8b603a4..605d50c97f 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3548,28 +3548,7 @@ __metadata: languageName: unknown linkType: soft -"@metamask/providers@npm:17.0.0": - version: 17.0.0 - resolution: "@metamask/providers@npm:17.0.0" - dependencies: - "@metamask/json-rpc-engine": "npm:^8.0.1" - "@metamask/json-rpc-middleware-stream": "npm:^7.0.1" - "@metamask/object-multiplex": "npm:^2.0.0" - "@metamask/rpc-errors": "npm:^6.2.1" - "@metamask/safe-event-emitter": "npm:^3.1.1" - "@metamask/utils": "npm:^8.3.0" - detect-browser: "npm:^5.2.0" - extension-port-stream: "npm:^3.0.0" - fast-deep-equal: "npm:^3.1.3" - is-stream: "npm:^2.0.0" - readable-stream: "npm:^3.6.2" - peerDependencies: - webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0 - checksum: 10/9e6b84120276035c9d7e776da4f7e18243116c53fd0c33efca17034971981164720e808dff055e871d08b9ed9d78dc9ebd0d974238baa599d7d91e1560fc1abb - languageName: node - linkType: hard - -"@metamask/providers@npm:^17.0.0": +"@metamask/providers@npm:17.1.1, @metamask/providers@npm:^17.0.0": version: 17.1.1 resolution: "@metamask/providers@npm:17.1.1" dependencies: