-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notification-services-push-controller): Add missing messenger action/events #4641
fix(notification-services-push-controller): Add missing messenger action/events #4641
Conversation
Thank you for these changes! LMK when this needs a review. Or feel free to merge with another external reviewer 🫡 |
@@ -1,2 +1,2 @@ | |||
export * as NotificationServicesController from './NotificationServicesController'; | |||
export * as NotificationsServicesPushController from './NotificationServicesPushController'; | |||
export * as NotificationServicesPushController from './NotificationServicesPushController'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use named exports instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notifications team is pursuing a different scheme with organizing their exports. It looks like they're planning to define export subpaths instead of enumerating named exports (see #4604).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's a bit messy for now. Once subpath exports get it, we'll clean up the imports used.
Explanation
Fixes various errors in the
NotificationServicesPushController
:*:getState
action using theControllerGetStateAction
utility type*:stateChange
event using theControllerStateChangeEvent
utility typeReferences
Changelog
@metamask/notification-services-controller
(major)Added
NotificationServicesPushControllerGetStateAction
,NotificationServicesPushControllerStateChangeEvent
(#4641)Changed
NotificationServicesPushControllerPushNotificationClicked
type toNotificationServicesPushControllerPushNotificationClickedEvent
(#4641)AllowedEvents
type forNotificationServicesPushControllerMessenger
tonever
(#4641)NotificationServicesPushControllerMessenger
must allow internal eventNotificationServicesPushControllerStateChangeEvent
(#4641)Fixed
NotificationServicesPushController
from "NotificationsServicesPushController" to "NotificationsServicesPushController" (#4641)getState
action in theActions
type forNotificationServicesPushControllerMessenger
with newNotificationServicesPushControllerGetStateAction
type (#4641)Checklist