Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace legacy eth-json-rpc deps #11952

Merged
merged 60 commits into from
Dec 13, 2024
Merged

fix: replace legacy eth-json-rpc deps #11952

merged 60 commits into from
Dec 13, 2024
+120 −147

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 22, 2024 •
edited by NicolasMassart
Loading

Description

Related issues

Expected to fix the following issues:

Blocked by

Manual testing steps

  1. Go to in-app browser
  2. Test connect with multiple dapps
  3. Perform transaciton on test dapp
  4. Go to this page...

Screenshots/Recordings

Screen.Recording.2024-06-24.at.22.46.41.mov

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 22, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Oct 22, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat force-pushed the chore/provider-middleware-filters-2 branch 2 times, most recently from 45873d6 to f68a6cf Compare October 22, 2024 12:56
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat mentioned this pull request Oct 22, 2024
Draft
7 tasks
@legobeat legobeat marked this pull request as ready for review October 22, 2024 13:32
@legobeat legobeat requested review from a team as code owners October 22, 2024 13:32
@legobeat legobeat force-pushed the chore/provider-middleware-filters-2 branch from f68a6cf to 8dbb040 Compare October 22, 2024 13:36
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@EtherWizard33 EtherWizard33 self-requested a review December 13, 2024 13:06
EtherWizard33
EtherWizard33 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving my previous approval :)

@NicolasMassart NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c3db051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/caab888a-37fd-4deb-b6b4-311f8e136322

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
76.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c3db051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/caab888a-37fd-4deb-b6b4-311f8e136322

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

1 similar comment
@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c3db051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/caab888a-37fd-4deb-b6b4-311f8e136322

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

ccharly
ccharly approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for accounts related files:

app/core/Encryptor/pbkdf2.test.ts

christopherferreira9
christopherferreira9 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for SDK

GuillaumeRx
GuillaumeRx approved these changes Dec 13, 2024
View reviewed changes
Copy link

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the snap side ✔️

@NicolasMassart NicolasMassart added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit d967a76 Dec 13, 2024
39 of 40 checks passed
@NicolasMassart NicolasMassart deleted the chore/provider-middleware-filters-2 branch December 13, 2024 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaoloureirop joaoloureirop joaoloureirop approved these changes

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@ccharly ccharly ccharly approved these changes

@mcmire mcmire Awaiting requested review from mcmire

@smilingkylan smilingkylan Awaiting requested review from smilingkylan

@tommasini tommasini Awaiting requested review from tommasini

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@owencraston owencraston Awaiting requested review from owencraston

@gantunesr gantunesr Awaiting requested review from gantunesr

@Cal-L Cal-L Awaiting requested review from Cal-L

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

@jclancy93 jclancy93 Awaiting requested review from jclancy93

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

Assignees

@NicolasMassart NicolasMassart

Labels
dependencies Pull requests that update a dependency file external-contributor release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.