Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metamask portfolio api #12904

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Add metamask portfolio api #12904

wants to merge 5 commits into from

Conversation

Bigshmow
Copy link

@Bigshmow Bigshmow commented Jan 8, 2025

Description

Adding the base fetch function to allow future tokens-search and tokens-discovery portfolio api endpoints to be consumed.

Related issues

Fixes:

Manual testing steps

  1. The api call in this PR cannot be tested manually, this is an initial integration.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Bigshmow Bigshmow added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: bac6ea3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ceee47b-414f-46c2-a3ba-8c490e42bacf

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Bigshmow Bigshmow changed the title Add portfolio api feat: Add portfolio api Jan 8, 2025
@Bigshmow Bigshmow added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1ad4b2b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dae857c7-711d-4ef6-8a3d-e369eab75439

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Bigshmow Bigshmow added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: beff8ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2eca7cc7-61a7-457f-8aaa-e24c2d5a9c3a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Bigshmow Bigshmow added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 77dbec8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aeabb1c5-a84d-4bcd-aed0-5c4ea457ecb3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Bigshmow Bigshmow marked this pull request as ready for review January 8, 2025 23:25
@Bigshmow Bigshmow requested review from a team as code owners January 8, 2025 23:25
@Bigshmow Bigshmow changed the title feat: Add portfolio api feat: Add metamask portfolio api Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-portfolio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants