From 6c459ccbb59d9b18bd9e2df71a9fcfbcd9ba2374 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Kubitz?= Date: Mon, 2 Dec 2024 13:00:31 +0100 Subject: [PATCH] PropertyPageNode: log full exception if any instead of popup only This issue did not show the root exception: https://github.com/eclipse-jdt/eclipse.jdt.debug/issues/570 --- .../org/eclipse/ui/internal/dialogs/PropertyPageNode.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/PropertyPageNode.java b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/PropertyPageNode.java index 3bd3e29cceb..109e0482f45 100644 --- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/PropertyPageNode.java +++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/PropertyPageNode.java @@ -13,6 +13,7 @@ *******************************************************************************/ package org.eclipse.ui.internal.dialogs; +import java.util.List; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.preference.IPreferencePage; @@ -58,8 +59,9 @@ public void createPage() { } catch (CoreException e) { // Just inform the user about the error. The details are // written to the log by now. - IStatus errStatus = StatusUtil.newStatus(e.getStatus(), WorkbenchMessages.PropertyPageNode_errorMessage); - StatusManager.getManager().handle(errStatus, StatusManager.SHOW); + IStatus errStatus = StatusUtil.newStatus(List.of(e.getStatus()), + WorkbenchMessages.PropertyPageNode_errorMessage, null); + StatusManager.getManager().handle(errStatus, StatusManager.SHOW | StatusManager.LOG); page = new EmptyPropertyPage(); } setPage(page);