Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having problems getting correct colors. #14

Open
AOrobator opened this issue Mar 12, 2014 · 0 comments
Open

Having problems getting correct colors. #14

AOrobator opened this issue Mar 12, 2014 · 0 comments

Comments

@AOrobator
Copy link

It seems that the algorithm you're using has a tough time picking out reds. I'm using your library to pick out colors for albums and here is the first example of something going not as expected.

A Star Is Born

The background color is pretty good. It could be a little darker to reflect that the album background isn't pure white. My main issue is with the primary color here. There are pretty much only two colors on the album, white and red. The red doesn't show up in any of the colors, be it primary, secondary, or detail color. In all of these examples, the colors are as follows:

  • Background color is from ColorArt.getBackgroundColor()
  • Song title is ColorArt.getPrimaryColor()
  • Artist is ColorArt.getSecondaryColor()
  • The time played and time left textviews are ColorArt.getPrimaryColor()
  • The progress bar on the seekbar is ColorArt.getSecondaryColor()
  • The draggable thumb on the seekbar is ColorArt.getPrimaryColor()

Here's another example

11:11pm

The background color is a dark brown/green. Ideally it would be a red or a white as those are the two most dominant colors in the image and they also touch the borders.

Yet another example:

9MM

For this album cover, the background color is good. What's weird is that the primary color is pink. There isn't really pink on the album cover, though there is a bit of red in the reflection of the sunglasses. It would make more sense for the primary color to be a black, white or brown.

Moar example:

Say Something

There should be red/magenta as the primary color.

Last example:

Witness

Nix the purple/lilac. Use the reds/oranges/light blues/blacks or whites. The background color should definitely be white here as that is also the background color of the album. Red or orange would work as well.

EDIT:

I found some more weird occurrences. In the following image, there shouldn't be any light blue.

More to Life

In the following image, there should not be pink.

Yiruma

In the future, similar to Chris Banes's ColorFinder, it would be nice to have a secondary text color which is either black or white depending on the brightness of the background color to ensure high visibility/readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant