You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that the algorithm you're using has a tough time picking out reds. I'm using your library to pick out colors for albums and here is the first example of something going not as expected.
The background color is pretty good. It could be a little darker to reflect that the album background isn't pure white. My main issue is with the primary color here. There are pretty much only two colors on the album, white and red. The red doesn't show up in any of the colors, be it primary, secondary, or detail color. In all of these examples, the colors are as follows:
Background color is from ColorArt.getBackgroundColor()
Song title is ColorArt.getPrimaryColor()
Artist is ColorArt.getSecondaryColor()
The time played and time left textviews are ColorArt.getPrimaryColor()
The progress bar on the seekbar is ColorArt.getSecondaryColor()
The draggable thumb on the seekbar is ColorArt.getPrimaryColor()
Here's another example
The background color is a dark brown/green. Ideally it would be a red or a white as those are the two most dominant colors in the image and they also touch the borders.
Yet another example:
For this album cover, the background color is good. What's weird is that the primary color is pink. There isn't really pink on the album cover, though there is a bit of red in the reflection of the sunglasses. It would make more sense for the primary color to be a black, white or brown.
Moar example:
There should be red/magenta as the primary color.
Last example:
Nix the purple/lilac. Use the reds/oranges/light blues/blacks or whites. The background color should definitely be white here as that is also the background color of the album. Red or orange would work as well.
EDIT:
I found some more weird occurrences. In the following image, there shouldn't be any light blue.
In the following image, there should not be pink.
In the future, similar to Chris Banes's ColorFinder, it would be nice to have a secondary text color which is either black or white depending on the brightness of the background color to ensure high visibility/readability.
The text was updated successfully, but these errors were encountered:
It seems that the algorithm you're using has a tough time picking out reds. I'm using your library to pick out colors for albums and here is the first example of something going not as expected.
The background color is pretty good. It could be a little darker to reflect that the album background isn't pure white. My main issue is with the primary color here. There are pretty much only two colors on the album, white and red. The red doesn't show up in any of the colors, be it primary, secondary, or detail color. In all of these examples, the colors are as follows:
Here's another example
The background color is a dark brown/green. Ideally it would be a red or a white as those are the two most dominant colors in the image and they also touch the borders.
Yet another example:
For this album cover, the background color is good. What's weird is that the primary color is pink. There isn't really pink on the album cover, though there is a bit of red in the reflection of the sunglasses. It would make more sense for the primary color to be a black, white or brown.
Moar example:
There should be red/magenta as the primary color.
Last example:
Nix the purple/lilac. Use the reds/oranges/light blues/blacks or whites. The background color should definitely be white here as that is also the background color of the album. Red or orange would work as well.
EDIT:
I found some more weird occurrences. In the following image, there shouldn't be any light blue.
In the following image, there should not be pink.
In the future, similar to Chris Banes's ColorFinder, it would be nice to have a secondary text color which is either black or white depending on the brightness of the background color to ensure high visibility/readability.
The text was updated successfully, but these errors were encountered: