Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite compatibility #29

Open
micah-redwood opened this issue Jan 13, 2023 · 1 comment
Open

Vite compatibility #29

micah-redwood opened this issue Jan 13, 2023 · 1 comment

Comments

@micah-redwood
Copy link

First off, thanks for this really helpful library. Great to have a bullet-proof import vs having to write try-catch statements myself.

I noticed that the package is currently incompatible with Vite. To replicate, just setup a new Vite project (Vite 3 or Vite 4, breaks in both), import the package, and run npm run dev (which runs vite command for HMR)

image

I'm guessing it has something to do with how this package is bundled for npm.

Any ideas? Thanks!

@etiennea
Copy link

etiennea commented Feb 7, 2023

Made a PR for compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants