Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Improve updates to settings mid-session #236

Open
1 task done
calderonsamuel opened this issue Nov 10, 2024 · 1 comment
Open
1 task done

[FR]: Improve updates to settings mid-session #236

calderonsamuel opened this issue Nov 10, 2024 · 1 comment
Labels
feature a feature request or enhancement help wanted ❤️ we'd love your help!

Comments

@calderonsamuel
Copy link
Collaborator

What would you like to have?

#230 and #235 are showing us that is not clear that the user needs to manually save settings after updating API service. To be fair, I don't think there is any chat service UI (Chatgpt, Claude, etc) that requires you to do the same.

So we need to either:

  1. Make this automatic (invisible)
  2. Ask user confirmation (semi-automatic, visible)

I'm inclined to think that most users want to change settings permanently, so we would get rid of that button (but can keep the Save for this session). This is mostly UX and I'm just reflecting what I personally prefer for my typical usage, so any comments would be welcome before jumping into implementation

Code of Conduct

  • I agree to follow this project's Code of Conduct
@calderonsamuel calderonsamuel added feature a feature request or enhancement help wanted ❤️ we'd love your help! labels Nov 10, 2024
@JamesHWade
Copy link
Collaborator

I vote to update semi-automatically with user confirmation. Options of "Save", "Save for This Session", and "Cancel" in the dialog make sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement help wanted ❤️ we'd love your help!
Projects
None yet
Development

No branches or pull requests

2 participants