Add tests for Service classes

src/main/java/dev/migwel/sts/domain/service/FromServiceFactory.java

@@ -4,9 +4,12 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.Nonnull;
+import javax.annotation.ParametersAreNonnullByDefault;
 import java.util.List;
 
 @Component
+@ParametersAreNonnullByDefault
 public class FromServiceFactory {
 
     private final List<FromService<?>> fromServices;
@@ -16,9 +19,11 @@ public FromServiceFactory(List<FromService<?>> fromServices) {
         this.fromServices = List.copyOf(fromServices);
     }
 
-    public <T extends FromRequest> FromService<T> getFromService(T fromRequest) {
+    @Nonnull
+    public <T extends FromRequest> FromService<T> getFromService(
+            Class<? extends FromRequest> requestClass) {
         for (FromService<?> fromService : fromServices) {
-            if (fromService.isRelevant(fromRequest.getClass())) {
+            if (fromService.isRelevant(requestClass)) {
                 return (FromService<T>) fromService;
             }
         }

src/main/java/dev/migwel/sts/domain/service/SaveService.java

@@ -23,13 +23,13 @@ public SaveService(FromServiceFactory fromServiceFactory, ToServiceFactory toSer
     }
 
     public <T extends FromRequest, U extends ToRequest> void save(T from, U to) {
-        FromService<T> fromService = fromServiceFactory.getFromService(from);
+        FromService<T> fromService = fromServiceFactory.getFromService(from.getClass());
         Optional<Song> optionalSong = fromService.search(from);
         if (optionalSong.isEmpty()) {
             logger.info("Could not find what's playing for " + from);
             return;
         }
-        ToService<U> toService = toServiceFactory.getToService(to);
+        ToService<U> toService = toServiceFactory.getToService(to.getClass());
         toService.save(optionalSong.get(), to);
     }
 }

src/main/java/dev/migwel/sts/domain/service/ToServiceFactory.java

@@ -7,7 +7,11 @@
 
 import java.util.List;
 
+import javax.annotation.Nonnull;
+import javax.annotation.ParametersAreNonnullByDefault;
+
 @Component
+@ParametersAreNonnullByDefault
 public class ToServiceFactory {
 
     private final List<ToService<?>> toServices;
@@ -17,9 +21,11 @@ public ToServiceFactory(List<ToService<?>> toServices) {
         this.toServices = List.copyOf(toServices);
     }
 
-    public <T extends ToRequest> ToService<T> getToService(T saveRequest) {
+    @Nonnull
+    public <T extends ToRequest> ToService<T> getToService(
+            Class<? extends ToRequest> requestClass) {
         for (ToService<?> toService : toServices) {
-            if (toService.isRelevant(saveRequest.getClass())) {
+            if (toService.isRelevant(requestClass)) {
                 return (ToService<T>) toService;
             }
         }

src/test/java/dev/migwel/sts/domain/service/FromServiceFactoryTest.java

@@ -0,0 +1,38 @@
+package dev.migwel.sts.domain.service;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import dev.migwel.sts.Application;
+import dev.migwel.sts.domain.model.FromRequest;
+
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
+
+@SpringJUnitConfig(Application.class)
+class FromServiceFactoryTest {
+
+    private final FromServiceFactory serviceFactory;
+
+    @Autowired
+    FromServiceFactoryTest(FromServiceFactory serviceFactory) {
+        this.serviceFactory = serviceFactory;
+    }
+
+    @Test
+    void getFromService() {
+        Class<?>[] permittedSearchRequests = FromRequest.class.getPermittedSubclasses();
+        for (Class<?> permittedSearchRequest : permittedSearchRequests) {
+            try {
+                serviceFactory.getFromService(
+                        (Class<? extends FromRequest>) permittedSearchRequest);
+            } catch (IllegalArgumentException e) {
+                fail(
+                        "Exception occurred while trying to get from service for request: "
+                                + permittedSearchRequest
+                                + ". Reason: "
+                                + e.getMessage());
+            }
+        }
+    }
+}

src/test/java/dev/migwel/sts/service/FromServiceTest.java → src/test/java/dev/migwel/sts/domain/service/FromServiceTest.java

@@ -1,4 +1,4 @@
-package dev.migwel.sts.service;
+package dev.migwel.sts.domain.service;
 
 import static org.junit.jupiter.api.Assertions.*;
 

src/test/java/dev/migwel/sts/domain/service/SaveServiceTest.java

@@ -28,7 +28,7 @@ class SaveServiceTest {
     @InjectMocks private SaveService saveService;
 
     @BeforeEach
-    private void before() {
+    public void before() {
         doReturn(fromService).when(fromServiceFactory).getFromService(any());
         lenient().doReturn(toService).when(toServiceFactory).getToService(any());
     }

src/test/java/dev/migwel/sts/domain/service/ToServiceFactoryTest.java

@@ -0,0 +1,38 @@
+package dev.migwel.sts.domain.service;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import dev.migwel.sts.Application;
+import dev.migwel.sts.domain.model.FromRequest;
+
+import dev.migwel.sts.domain.model.ToRequest;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
+
+@SpringJUnitConfig(Application.class)
+class ToServiceFactoryTest {
+
+    private final ToServiceFactory serviceFactory;
+
+    @Autowired
+    ToServiceFactoryTest(ToServiceFactory serviceFactory) {
+        this.serviceFactory = serviceFactory;
+    }
+
+    @Test
+    void getFromService() {
+        Class<?>[] permittedSearchRequests = ToRequest.class.getPermittedSubclasses();
+        for (Class<?> permittedSearchRequest : permittedSearchRequests) {
+            try {
+                serviceFactory.getToService((Class<? extends ToRequest>) permittedSearchRequest);
+            } catch (IllegalArgumentException e) {
+                fail(
+                        "Exception occurred while trying to get to service for request: "
+                                + permittedSearchRequest
+                                + ". Reason: "
+                                + e.getMessage());
+            }
+        }
+    }
+}

src/test/java/dev/migwel/sts/service/ToServiceTest.java → src/test/java/dev/migwel/sts/domain/service/ToServiceTest.java

@@ -1,4 +1,4 @@
-package dev.migwel.sts.service;
+package dev.migwel.sts.domain.service;
 
 import static org.junit.jupiter.api.Assertions.*;