Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace withIO with input and output stream parameters #21

Open
drewish opened this issue Oct 24, 2017 · 2 comments
Open

Replace withIO with input and output stream parameters #21

drewish opened this issue Oct 24, 2017 · 2 comments

Comments

@drewish
Copy link
Contributor

drewish commented Oct 24, 2017

This is a follow up to #16 (comment). I'd like to switch from the current method of replacing the global $stdin and $stdout to having the ScottKit::Game accept a input and output streams in the options has. We can default to the current values so it should be a pretty transparent change.

@MikeTaylor
Copy link
Owner

Give me a moment to think this through, please. I want to remember why I made withIO. I admit that what you propose sounds saner, but I must have had a reason!

@MikeTaylor
Copy link
Owner

I admit that withIO is a slightly eccentric approach -- I am still trying to remember why I did it this way -- but is is actively preventing you from doing what you want? Or is this just fixing a smell?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants