-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move network ID from Rosetta to GraphQL #14042
Conversation
!ci-build-me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but you'll have to fix the build (see failing unit test)
!ci-build-me |
1 similar comment
!ci-build-me |
!approved-for-mainnet |
!ci-build-me |
3 similar comments
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-builld-me |
!ci-build-me |
1a34833
to
d2e5fc0
Compare
!ci-build-me |
1 similar comment
!ci-build-me |
!ci-build-me |
1 similar comment
!ci-build-me |
7dbf83a
to
a2c110d
Compare
The query returns the chain-agnostic identifier of the network conforming with the standard https://github.com/ChainAgnostic/namespaces.
a2c110d
to
b855c0a
Compare
!ci-build-me |
!ci-build-me |
!approved-for-mainnet |
We need the node to conform to the Chain Agnostic Standard so that it can be handled by more wallets. To do it, it should return a human-readable identifier of the network it participates in (see CASA namespace for Mina Protocol). The identifier should consist of 2 parts separated by a colon:
For instance mainnet's identifier should look like this:
mina:mainnet
. This identifier should be tied down to Rosetta's network identifier.The query to obtain the identifier is:
To which the daemon will respond for instance:
Explain your changes:
ledger.name
from the runtime config as network identifier.mina
.networkID
returning the ledger name prefixed with constantmina:
.network_identifier
from the daemon.Explain how you tested your changes:
rosetta-cli
tests to make sure that Rosetta works properly after this change.Checklist: