Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child_processes: ensure stderr/stdout get flushed #14696

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Child_processes: ensure stderr/stdout get flushed #14696

merged 3 commits into from
Jan 10, 2024

Conversation

emberian
Copy link
Contributor

@emberian emberian commented Dec 11, 2023 •
edited
Loading

This ensures that libp2p_helper output does not get lost when the process crashes. Tested by adding a variable-length sleep+panic to the helper and never losing the stderr output over a few runs.

Follow up to #14397 I believe?

@emberian emberian requested a review from a team as a code owner December 11, 2023 21:54
@emberian emberian changed the base branch from develop to berkeley December 11, 2023 22:00
@emberian emberian requested review from a team as code owners December 11, 2023 22:00
@emberian emberian force-pushed the fix/keep-helper-stderr branch 2 times, most recently from f00df80 to ff92b1c Compare December 11, 2023 22:01
@emberian emberian changed the base branch from berkeley to rampup December 13, 2023 19:57
@emberian emberian requested a review from a team as a code owner December 13, 2023 19:57
@emberian emberian force-pushed the fix/keep-helper-stderr branch from ff92b1c to 2d386c0 Compare December 13, 2023 19:59
@deepthiskumar
Copy link
Member

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

deepthiskumar
deepthiskumar previously requested changes Jan 6, 2024
View reviewed changes
Copy link
Member

@deepthiskumar deepthiskumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for rampup8 release

@emberian emberian requested a review from deepthiskumar January 8, 2024 21:25
@deepthiskumar deepthiskumar dismissed their stale review January 9, 2024 21:51

include in rampup8

@emberian
Copy link
Contributor Author

emberian commented Jan 9, 2024

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-nightly-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 435625b into rampup Jan 10, 2024
36 checks passed
@deepthiskumar deepthiskumar deleted the fix/keep-helper-stderr branch January 10, 2024 05:44
@deepthiskumar
Copy link
Member

@emberian please raise if any of the integration test triggered by ci-nightly-me fails https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/1083

@mrmr1993 mrmr1993 mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghost-not-in-the-shell ghost-not-in-the-shell ghost-not-in-the-shell approved these changes

@nholland94 nholland94 nholland94 approved these changes

@joaosreis joaosreis joaosreis approved these changes

@deepthiskumar deepthiskumar Awaiting requested review from deepthiskumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emberian @deepthiskumar @joaosreis @nholland94 @ghost-not-in-the-shell