-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit zkApp Commands Hardcap #14813
Limit zkApp Commands Hardcap #14813
Conversation
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
I did one simple test on this locally. I just ran a single bp node and set the limit to 0. I was told the I will try a more sophisticated set up next. |
!ci-build-me |
I conducted the test as outlined in the RFC (i.e. a network with a seed bp node without this fix and a non-seed/non-bp node with this fix, and checked that the block height never increased for the latter when zkapp transactions started). The test performed as expected. |
!ci-build-me |
@georgeee Thanks for the review. Could you approve when you're happy? |
!ci-build-me |
@georgeee Do you know if there is an issue with Nix? The pipeline seems to be failing there. Thanks. |
!ci-build-me |
!ci-build-me |
!ci-build-me |
@ejMina226 some errors appear on Ci after merge of |
Hi @georgeee . It's a strange error. It's saying that there's an argument missing to the following function (Zkapp_command.Valid.to_valid) However, I didn't touch this function. |
Actually, I've fixed one issue. |
!ci-build-me |
!approved-for-mainnet |
@georgeee @mrmr1993 @deepthiskumar Can this be merged? |
Limit zkApp Commands to n >=0 in case of emergency
(See #14783)