Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork_config loses previous_ label #15077

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Fork_config loses previous_ label #15077

merged 5 commits into from
Feb 14, 2024

Conversation

emberian
Copy link
Contributor

@emberian emberian commented Feb 8, 2024 •
edited
Loading

Closes #15070

Berkeley: #15079

(the berkeley version is compatible with develop, unlike this one)

@emberian emberian requested a review from a team as a code owner February 8, 2024 21:34
@emberian emberian force-pushed the fix/fork-config-rename branch from 0f7d0ff to 1b23e30 Compare February 8, 2024 21:43
@emberian
[BREAKING] Fork_config receives current state hash
0939d74 
The previous state hash would be the -2 block from the perspective
of the genesis of the new chain.
@emberian
Copy link
Contributor Author

emberian commented Feb 8, 2024

!ci-build-me

@emberian emberian mentioned this pull request Feb 9, 2024
Merged
@deepthiskumar deepthiskumar added the P0 Urgent label Feb 9, 2024
emberian
emberian commented Feb 12, 2024
View reviewed changes
src/config/fork.mlh Outdated Show resolved Hide resolved
@emberian
Copy link
Contributor Author

!ci-build-me

ghost-not-in-the-shell
ghost-not-in-the-shell approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@ghost-not-in-the-shell ghost-not-in-the-shell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to runtime_config looks good. It's using the current state_hash instead of previous_state_hash. This should fix the bug we saw in the hf testnet.

@emberian emberian mentioned this pull request Feb 13, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2024

⚠️ The sha of the head commit of this PR conflicts with #15101. Mergify cannot evaluate rules on this PR. ⚠️

@emberian emberian force-pushed the fix/fork-config-rename branch from 8daa795 to 0939d74 Compare February 13, 2024 21:32
@emberian
Copy link
Contributor Author

!ci-build-me

@mrmr1993 mrmr1993 mentioned this pull request Feb 13, 2024
Merged
@mrmr1993
Copy link
Member

!ci-build-me

@mrmr1993 mrmr1993 merged commit 524c0c6 into compatible Feb 14, 2024
15 checks passed
@mrmr1993 mrmr1993 deleted the fix/fork-config-rename branch February 14, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghost-not-in-the-shell ghost-not-in-the-shell ghost-not-in-the-shell approved these changes

@bkase bkase Awaiting requested review from bkase

@psteckler psteckler Awaiting requested review from psteckler

@aneesharaines aneesharaines Awaiting requested review from aneesharaines

@mrmr1993 mrmr1993 Awaiting requested review from mrmr1993

@nholland94 nholland94 Awaiting requested review from nholland94

Assignees
No one assigned
Labels
P0 Urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emberian @mrmr1993 @ghost-not-in-the-shell @deepthiskumar