Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shorthand flex #11

Open
davesnx opened this issue Mar 5, 2020 · 3 comments
Open

Support shorthand flex #11

davesnx opened this issue Mar 5, 2020 · 3 comments

Comments

@davesnx
Copy link

davesnx commented Mar 5, 2020

Hey @alexfedoseev

I'm working on https://github.com/davesnx/re-styled-ppx and would be amazing to have support for shorthand flex properties, like flex('some(1., 1.)) or flex('some(1.)).

The change wouldn't be massive, it's somehow making grow and basis optionals.
https://github.com/MinimaHQ/re-css/blob/master/src/Css.re#L1785-L1794

WDYT?

PD. I'm happy to jump into making a PR

@davesnx davesnx changed the title Support flex(`some(1., 1.)) Support shorthand flex Mar 5, 2020
@alex35mil
Copy link
Member

Hey @davesnx, sounds good to me. But please check w/ @jchavarri if it would be ok for bs-emotion since it's the main consumer at the moment.

@davesnx
Copy link
Author

davesnx commented Mar 6, 2020

Sure, will do that. Thanks @alexfedoseev

Do we have any list of support with emotion? I know that these things take a lot of time, but just in case.

@davesnx
Copy link
Author

davesnx commented Mar 6, 2020

I created a list of "all CSS properties" and some that aren't supported in bs-emotion. https://github.com/davesnx/re-styled-ppx/blob/master/demo/src/index.re

Wasn't the point of this issue, but maybe cool to have somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants