Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distributed lock to discover hosts #8

Open
s3rj1k opened this issue Nov 4, 2024 · 5 comments
Open

Add distributed lock to discover hosts #8

s3rj1k opened this issue Nov 4, 2024 · 5 comments
Assignees
Labels
feature Adds new functionality os:nova OpenStack Nova size-L Change size large (CL: 100...499)

Comments

@s3rj1k
Copy link
Collaborator

s3rj1k commented Nov 4, 2024

refs:

@s3rj1k s3rj1k added os:nova OpenStack Nova size-L Change size large (CL: 100...499) labels Nov 4, 2024
@s3rj1k s3rj1k self-assigned this Nov 20, 2024
@s3rj1k
Copy link
Collaborator Author

s3rj1k commented Nov 21, 2024

we have discover_hosts_in_cells_interval set to 2 min by default, and at same time we start discovery job each time number of computes is changed in daemonset. I wondered if we can fix code in discover_cells mechanism so concurrent runs of nova-manage cell_v2 discover_hosts and periodic tasks do not lead to failures in scheduling

periodics: https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L113
host_mapping_obj.discover_hosts uses https://github.com/openstack/nova/blob/master/nova/objects/host_mapping.py#L248

CLI: https://docs.openstack.org/nova/latest/cli/nova-manage.html#cell-v2-discover-hosts

Coordinator: https://docs.openstack.org/tooz/1.53.0/tutorial/coordinator.html

@s3rj1k
Copy link
Collaborator Author

s3rj1k commented Nov 22, 2024

RFE proposed: https://bugs.launchpad.net/nova/+bug/2089386

@s3rj1k s3rj1k moved this from Triage to RFE: New in OpenStack Downstream to Upstream Nov 22, 2024
@s3rj1k s3rj1k moved this from RFE: New to RFE: Opinion in OpenStack Downstream to Upstream Nov 22, 2024
@s3rj1k s3rj1k added the feature Adds new functionality label Nov 22, 2024
@s3rj1k
Copy link
Collaborator Author

s3rj1k commented Nov 26, 2024

Meeting: https://meetings.opendev.org/meetings/nova/2024/nova.2024-11-26-16.00.log.html
(scroll down to "#topic Open discussion")

@s3rj1k
Copy link
Collaborator Author

s3rj1k commented Nov 27, 2024

@s3rj1k s3rj1k moved this from RFE: Opinion to Spec: New in OpenStack Downstream to Upstream Nov 27, 2024
@s3rj1k
Copy link
Collaborator Author

s3rj1k commented Nov 27, 2024

<sean-k-mooney> where as we ahve dicussed how to remove tooz form teh code base 
<sean-k-mooney> at least twice in the last year or two
...
<sean-k-mooney> the main concern with tooz by the way is its overall mantance
...
<s3rj1k> btw, is there a formal doc on tooz deprecation?
<sean-k-mooney> its not deprecated as a lib
<sean-k-mooney> so the only usage of it in nova is the ironic driver and we deprecated the fature that uses it in that
<s3rj1k> so for nova removal in this case
<sean-k-mooney> currently the ironic drivcer can use manual sharding or a dynmic hashring(provided by tooz)
<sean-k-mooney> the dynmaic hash ring is deprecated for removal which would have removed tooz as a side effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds new functionality os:nova OpenStack Nova size-L Change size large (CL: 100...499)
Projects
Status: Spec: New
Development

No branches or pull requests

1 participant