Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken links #29

Open
1 task done
slowkow opened this issue Nov 15, 2024 · 8 comments
Open
1 task done

broken links #29

slowkow opened this issue Nov 15, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@slowkow
Copy link

slowkow commented Nov 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Offending URL

https://mithril.js.org/examples.html

Issue description

I was exploring Mithril today, and I tried following some of the links in the documentation pages. Unfortunately, I hit a lot of 404 errors. So, I wanted to let you know about them here.

On the Examples page (https://mithril.js.org/examples.html), these links are broken (404):

https://mithril.js.org/examples.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/animation/mosaic.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/dbmonster/mithril/index.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/editor/index.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/svg/clock.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/svg/ring.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/svg/tiger.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/threaditjs/index.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/todomvc/index.html

The link to Tic Tac Toe is broken, and it takes me here: https://flems.io/


On the Framework comparison page (https://mithril.js.org/framework-comparison.html), these links are broken (404):

https://mithril.js.org/framework-comparison.html
        404     https://mithril.js.org/request.md#file-uploads
        404     https://mithril.js.org/route.md#authentication
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/dbmonster/angular/index.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/dbmonster/mithril/index.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/dbmonster/react/index.html
        404     https://raw.githack.com/MithrilJS/mithril.js/master/examples/dbmonster/vue/index.html

Here is a much longer list of 404 errors all over the documentation website:

mithril.js.org.txt

@dead-claudia dead-claudia transferred this issue from MithrilJS/mithril.js Nov 15, 2024
@dead-claudia
Copy link
Member

dead-claudia commented Nov 16, 2024

Notes for later:

  • Fixed raw.githack.com/* links in example.md
  • Fixed raw.githack.com/* links in framework-comparison.md
  • Flems links are malformed in example.md
  • Not corrected *.md links in framework-comparison.md, I suspect a build script issue

@dead-claudia
Copy link
Member

Further fixes are invited, of course.

@dead-claudia dead-claudia added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 16, 2024
@dead-claudia
Copy link
Member

Fixed all the non-archive links to markdown pages with anchors.

@dead-claudia
Copy link
Member

Note: the archives are low-priority, and will probably need a large scripted fix as they're just all compiled HTML.

@dead-claudia
Copy link
Member

@slowkow Could you re-run your scripts and separate their outputs into archive/ and non-archive/?

Everything except the Flems links should be fixed, though admittedly the list is awkward to go through on mobile.

@slowkow
Copy link
Author

slowkow commented Nov 18, 2024

@dead-claudia Thank you so much for the quick fix!

I ran muffet again with --exclude archive and this is the result I see now:

https://mithril.js.org/keys.html
        id #linking-model-data-to-views not found       https://mithril.js.org/keys.html#linking-model-data-to-views
https://mithril.js.org/animation.html
        403     https://greensock.com/gsap
https://mithril.js.org/framework-comparison.html
        id #authentication not found    https://mithril.js.org/route.html#authentication
https://mithril.js.org/route.html
        id #The_pushState()_method not found    https://developer.mozilla.org/en-US/docs/Web/API/History_API#The_pushState%28%29_method
        id #reinitializing-views-with-single-child-keyed-fragments not found    https://mithril.js.org/route.html#reinitializing-views-with-single-child-keyed-fragments
https://mithril.js.org/examples/dbmonster/vue/index.html
        404     https://vuejs.org/js/vue.min.js
https://mithril.js.org/examples/dbmonster/angular/index.html
        404     https://code.angularjs.org/2.0.0-beta.17/Rx.umd.js
        404     https://code.angularjs.org/2.0.0-beta.17/angular2-all.umd.js
        404     https://code.angularjs.org/2.0.0-beta.17/angular2-polyfills.js
        404     https://mithril.js.org/examples/dbmonster/lib/bootstrap.min.css
https://mithril.js.org/signatures.html
        id #mrouteset not found https://mithril.js.org/signatures.html#mrouteset
https://mithril.js.org/stream.html
        id #combiner not found  https://mithril.js.org/stream.html#combiner
        id #either-type not found       https://github.com/sanctuary-js/sanctuary#either-type
        id #functor not found   https://github.com/fantasyland/fantasy-land#functor
        id #lifter not found    https://mithril.js.org/stream.html#lifter
        id #stream-combine not found    https://mithril.js.org/stream.html#stream-combine
        id #stream-lift not found       https://mithril.js.org/stream.html#stream-lift
        id #streamfantasy-landof-1 not found    https://mithril.js.org/stream.html#streamfantasy-landof-1
https://mithril.js.org/examples/threaditjs/index.html
        lookup threaditjs.com on 127.0.0.53:53: server misbehaving      https://threaditjs.com/reset.css
        lookup threaditjs.com on 127.0.0.53:53: server misbehaving      https://threaditjs.com/shared.css
        lookup threaditjs.com on 127.0.0.53:53: server misbehaving      https://threaditjs.com/shared.js

@slowkow
Copy link
Author

slowkow commented Nov 18, 2024

Here is an attachment that includes about 2000 or so broken archive links:

mithril.js.org.txt

@dead-claudia
Copy link
Member

Okay, I'll go ahead and state that the ThreaditJS example won't be fixed right away. Once I get another chance, I'll resolve the other links in that non-archive list.

Note to whoever fixes it:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants