Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The internal redirect to the default route on failure isn't invalidating the current updater function. #2505

Open
dead-claudia opened this issue Aug 7, 2019 · 0 comments
Assignees
Labels
Area: Core For anything dealing with Mithril core itself Type: Bug For bugs and any other unexpected breakage

Comments

@dead-claudia
Copy link
Member

It's all caused by this line which isn't directly delegating to m.route.set, but is instead using an internal call skipping the reset logic.

It's not causing any apparent bugs, just taking up more space than necessary. The relevant variable set, lastUpdate could probably just be made a simple object token, so the closure isn't itself being directly persisted.

I've conservatively marked it as a bug, in case there is actual observably buggy behavior here.

@dead-claudia dead-claudia added the Type: Bug For bugs and any other unexpected breakage label Aug 7, 2019
@dead-claudia dead-claudia self-assigned this Aug 7, 2019
@dead-claudia dead-claudia moved this to Low priority in Triage/bugs Sep 2, 2024
@dead-claudia dead-claudia added the Area: Core For anything dealing with Mithril core itself label Sep 2, 2024
@dead-claudia dead-claudia mentioned this issue Oct 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core For anything dealing with Mithril core itself Type: Bug For bugs and any other unexpected breakage
Projects
Status: Low priority
Development

No branches or pull requests

1 participant