Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We have two change logs #2777

Open
pygy opened this issue May 30, 2022 · 4 comments
Open

We have two change logs #2777

pygy opened this issue May 30, 2022 · 4 comments
Assignees
Labels
Area: Documentation For anything dealing mainly with the documentation itself Type: Bug For bugs and any other unexpected breakage

Comments

@pygy
Copy link
Member

pygy commented May 30, 2022

We currently have

From now on, it would seem reasonable to rely on the automated logs. If pr-release is flexible enough, we could tell it to update changelog.md. If it isn't we can move the old entries to recent-changes.md and special-case that file in the build-docs script to put its content in https://mithril.js.org/changelog.html.

Edit, actually, https://mithril.js.org/recent-changes.html is live, but not linked to from anywere.

@pygy pygy added the Type: Bug For bugs and any other unexpected breakage label May 30, 2022
@pygy pygy assigned dead-claudia, JAForbes and pygy and unassigned dead-claudia May 30, 2022
@JAForbes
Copy link
Collaborator

Yep the default behaviour is to write to docs/changelog.md and it simply prepends to the existing file. The path is specified in the merge yml link

--changelog ./docs/recent-changes.md

Needs to change to:

--changelog ./changelog.md

I'll try and find time for a PR soon, but if not, that is all that needs to change.

@tbreuss
Copy link
Contributor

tbreuss commented May 31, 2022

@JAForbes I would love to do this (easy) task.

@pygy
Copy link
Member Author

pygy commented May 31, 2022

Sure! It is probably a bit more involved than just moving the content of recent-changes.md to changelog.md and updating the configuration, because...

  • The title structure is incompatible (I'd modify the old ones to match what PR-release does)
  • The old change log has a TOC (which is nice, but not mandatory...

If you want to try and generate one, you can have a look at https://github.com/compose-regexp/compose-regexp.js/blob/main/scripts/build-toc.js which should work with few modifications. The script currently replaces the TOC in the middle of the page, but it should instead move it back at the top after pr-release prepends its changes.

const tocMatcher = sequence(lookBehind('<!-- START toc -->\n'), /[^]*?/, lookAhead('<!-- END toc -->'))

should become

const tocMatcher = /<!-- START toc -->[^]*?<!-- END toc -->/

You can add the corresponding tags around the TOC at the start of the file, and tweak build-toc to move the TOC rather than replacing it.

(note that I'm fine not having a TOC there)

@modir
Copy link

modir commented Jan 4, 2023

In changelog.md is the date of release mentioned as well. In recent-changes.md this information missing. Would it be possible to add the date of the release automatically?

@dead-claudia dead-claudia added the Area: Documentation For anything dealing mainly with the documentation itself label Jan 18, 2023
@dead-claudia dead-claudia moved this to High priority in Triage/bugs Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation For anything dealing mainly with the documentation itself Type: Bug For bugs and any other unexpected breakage
Projects
Status: High priority
Development

No branches or pull requests

5 participants