-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet: Update to .NET 8 and most recent protobuf #131
Conversation
@bdferris-v2 Are you able to take a look at this? I haven't had any bandwidth to work on GTFS stuff lately :( |
Two questions:
|
I am a bit late in this discussion, but I would like to butt in. I would recommend targetting neither .NET 6 or .NET 8 but targetting .NET Standard 2.0 (or .1) instead. Targetting this gives the widest available range of compatibility as seen here. https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0 Targetting specific versions should only be done if you are going for a feature that is only available in that specific target framework. |
I ended up doing that one for comparison. Converted to .NET standard 2.0 and the new "SDK" style for .csproj's. Kept is as a draft to not overshadow this PR (didnt upgrade protobuf for example) |
I like @EnessenE's draft PR - it's simple and to the point, and having it be a net standard library just makes sense for a library of this purpose. It's been nearly 3 months without any discussion about this and I would love to have a brand new application I am working on be .NET 8 instead of .NET (framework) 4.8. What would be holding back bringing this PR for net standard 2.0 out of draft, rejecting the other one that has the aforementioned issues, and approving the PR for net standard 2.0? |
First, I apologize for my long inactivity.
I'll try to work it in by the end of the week. |
I think it's ready for review, @bdferris-v2. |
Thanks for the motion on this, I really appreciate it :) |
Small afterwards note: would be nice if someone pushed this to nuget ;) |
@bdferris-v2 is one of the owners in the NuGet gallery :) |
@bdferris-v2 any chance a NuGet package can be created which encapsulates this change? We've made a private Nuget package for our internal use with .net 8 but I'd like to use the public version when possible. |
Created .NET 8 version which is the most recent version of .NET Core (#56) and a LTS successor of .NET 6 (#127).