Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make GtfsTableDescriptor.required a mutable property #1566

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

bdferris-v2
Copy link
Collaborator

Per discussion in #1564, I'm looking to add base API support for changing the "required" status of some GTFS files/tables at run-time, as opposed to compile time. This PR achieves that by making "required" a mutable field in GtfsTableDescriptor to support dynamic configuration. Additionally, this PR consolidates some duplicate "isRequired" methods from GtfsTableContainer to make GtfsTableDescriptor the sole source of this info.

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

…equired or not, removing duplicate methods in GtfsTableContainer. Additionally, make "required" a mutable field in GtfsTableDescriptor to support dynamic configuration of which files are required and which aren't.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1470 sources (~0 %) are corrupted.
Commit: 707890d
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@emmambd emmambd requested review from qcdyx and jcpitre and removed request for qcdyx September 11, 2023 14:53
Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1470 sources (~0 %) are corrupted.
Commit: 1dca978
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2 bdferris-v2 merged commit 00888ba into master Sep 12, 2023
333 checks passed
@bdferris-v2 bdferris-v2 deleted the issue/1564/fares-only branch September 12, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants