Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GBFS v3 feed count on the batch processing #830

Open
emmambd opened this issue Nov 18, 2024 · 1 comment
Open

Fix GBFS v3 feed count on the batch processing #830

emmambd opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@emmambd
Copy link
Contributor

emmambd commented Nov 18, 2024

Describe the bug

Right now the metrics dashboard says there's 54 v3 feeds, but there's actually 85. Since this isn't reliable, our internal team can't use the metrics dashboard for GBFS currently.

This should be fixed for the preprocessed December metrics report.

Steps/Code to Reproduce

See above

Expected Results

Returns 85 GBFs v3 feeds

Actual Results

Returns 54 GBFS v3 feeds

Screenshots

No response

Files used

No response

Additional notes

No response

@emmambd emmambd added the bug Something isn't working label Nov 18, 2024
@jcpitre jcpitre changed the title Fix GBFS v3 feed count on the metrics dashboard Fix GBFS v3 feed count on the batch processing Nov 18, 2024
@cka-y cka-y self-assigned this Nov 26, 2024
@cka-y
Copy link
Contributor

cka-y commented Nov 27, 2024

Error Types Encountered in PROD

Based on the dataset_trace for the GBFS_VALIDATION pipeline stage, I identified the following error categories. Some of these issues will require fixes, while others are expected behavior or not fixable due to external constraints.

Error Type Count Example Stable IDs (Sample) Should Fix?
403 Forbidden (Google Storage) 297 Error processing GBFS files: 403 POST https://storage.googleapis.com/... : "functions-service-account@mobility-feeds-prod.iam.gserviceaccount.com does not have storage.objects.delete access..." ['gbfs-nextbike_ng', 'gbfs-nextbike_tv', 'gbfs-bcycle_greenbikeslc', ...] ✅ Fix Required
404 Not Found 64 Error processing GBFS files: 404 Client Error: NOT FOUND for url: https://gbfs.getapony.com/v1/grenoble/en/gbfs.json ['gbfs-pony_Grenoble', 'gbfs-nextbike_py', 'gbfs-lime_verona', ...] ❌ Not Fixable
Maximum Executions Reached 17 Maximum executions reached for gbfs-boltfredrikstad. ['gbfs-boltfredrikstad', 'gbfs-tierlorenskog', 'gbfs-tierbaerum', ...] ❌ Expected Behavior
Connection Pool Errors 5 HTTPSConnectionPool(host='belfort-gbfs.klervi.net', port=443): Max retries exceeded with url: /gbfs/gbfs.json ['gbfs-Optymo_FR_Belfort', 'gbfs-montpellier', 'gbfs-1227', ...] ❌ Not Fixable
400 Client Error 4 Error processing GBFS files: 400 Client Error: Bad Request for url: https://eu-mobility.joyride.tech/api/v1/gbfs/... ['gbfs-hoppy_Mechelen', 'gbfs-hoppy_Blankenberge', 'gbfs-hoppsharing_gent', ...] ❌ Not Fixable
Parsing Errors 4 Error processing GBFS files: 'data' ['gbfs-check_nijmegen', 'gbfs-check_zwolle', 'gbfs-check_lansingerland', ...] ❓ Investigate
Other Errors 4 Various, including: 403 Client Error, 500 Server Error, 401 Client Error, and Expecting value: line 1 column 1 (char 0) ['gbfs-velyceo', 'gbfs-biketobike', 'gbfs-neuron_chc', ...] ❓ Investigate
UniqueViolation Errors 3 Error validating GBFS feed: (psycopg2.errors.UniqueViolation) duplicate key value violates unique constraint "gbfsnotice_pkey" ['gbfs-oslobysykkel', 'gbfs-trondheimbysykkel', 'gbfs-kolumbusbysykkel'] ✅ Fix Required

Legend:

  • Fix Required: These issues are within our control and should be resolved.
  • Not Fixable: External issues, such as 404 errors for feeds that no longer exist or expected behaviors.
  • Investigate: Requires further analysis to determine if it is a fixable issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants