Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACTR importer condition typo? #497

Open
kmantel opened this issue Feb 1, 2024 · 1 comment
Open

ACTR importer condition typo? #497

kmantel opened this issue Feb 1, 2024 · 1 comment

Comments

@kmantel
Copy link
Contributor

kmantel commented Feb 1, 2024

# Conditions
cond_dm = Condition(type="Always")
cond_retrieval = Condition(type="JustRan", dependencies=dm_node.id)
cond_goal = Condition(type="Always")
cond_pm = Condition(type="Always")
cond_pattern = Condition(
type="And",
dependencies=[
Condition(type="EveryNCalls", dependencies=retrieval_node.id, n=1),
Condition(type="EveryNCalls", dependencies=goal_node.id, n=1),
Condition(type="EveryNCalls", dependencies=dm_node.id, n=1),
],
)

Should

Condition(type="EveryNCalls", dependencies=dm_node.id, n=1),

be

 Condition(type="EveryNCalls", dependencies=pm_node.id, n=1), 

instead? There's an edge from pm_node (not dm_node) to pattern_node.

@dawit-andargachew
Copy link

Hey, I'm Dawit. Glad to be here.

Thanks to this project, I've found an exciting opportunity to work on AI/ML-related tasks. With my prior experience in AI/ML internships and UI development, I'm eager to contribute my skills to this project.

I am getting my hands dirty on Jupyter Notebook by experimenting with MDF models. I have been tinkering with Streamlit as well to create some user interfaces. It's been a fun experience, especially considering my previous experience with Streamlit.

I would love to start my contribution by fixing the issue mentioned above. ✌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants