Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certain leftover images being entirely marked #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jedenastka
Copy link
Contributor

@jedenastka jedenastka commented Sep 9, 2024

This is actually two separate issues:

  • If one image is used as an input more than once, each run will overwrite the marked area
    Fixed by keeping the leftovers in memory the whole run, then writting them to disk after the rest of processing is done.
  • Clipping marks the whole area, instead only of the clipped part
    Fixed by using the box used for clipping for marking leftovers as well.

Before:

After:

Fixes #9.

This is actually two separate issues:

- If one image is used as an input more than once, each run will
  overwrite the marked area

Fixed by keeping the leftovers in memory the whole run, then writting
them to disk after the rest of processing is done.

- Clipping marks the whole area, instead only of the clipped part

Fixed by using the box used for clipping for marking leftovers as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leftover files seemingly unclear as to what regions are unused
1 participant