Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(dark-theme): persist user selected mode #454

Open
120EE0692 opened this issue Jul 18, 2023 · 1 comment
Open

bug(dark-theme): persist user selected mode #454

120EE0692 opened this issue Jul 18, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@120EE0692
Copy link
Member

Describe the bug

Currently user theme is not persisting.
When the user chooses either the dark or light mode and subsequently refreshes the page, the theme reverts back to the default setting.

The synchronization of tabs is not in place, meaning that if the user switches to dark mode in one tab, the other tabs will not reflect the change.

@120EE0692 120EE0692 added the bug Something isn't working label Jul 18, 2023
@rutajdash
Copy link
Member

Currently user theme is not persisting.
When the user chooses either the dark or light mode and subsequently refreshes the page, the theme reverts back to the default setting.
Consider the use of a service worker or some kind of global state library for this. Or maybe even persist the information in cookies or local storage.

The synchronization of tabs is not in place, meaning that if the user switches to dark mode in one tab, the other tabs will not reflect the change.
To my knowledge, since each tab essentially is running a completely separate and detached instance of the application, this cannot be synced in real time, but each instance should be able to fetch the updated variable on refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

3 participants