Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ⏫ upgrade to Polkadot SDK v1.14.0 #218

Merged
merged 42 commits into from
Oct 7, 2024
Merged

Conversation

TDemeco
Copy link
Contributor

@TDemeco TDemeco commented Oct 7, 2024

v1.13.0 to v1.14.0 - Polkadot SDK Upgrade

  • Changelog for Node Dev:
    • #4730 - Upgrade jsonrpsee to v0.23.1 to add Extensions, update hyper, http, soketto and related crates, and modify the subscription API for the client.
      • Note: update StorageHub to use v0.23.1
  • Changelog for Runtime Dev:
    • #3940 - Add request revenue info to the broker pallet, as part of RFC5 - Coretime Interface
    • #4831 - Remove unused config parameters ApproveOrigin and OnSlash from pallet-treasury. OnSlash is now a config parameter of the bounties and tips pallets.
    • #4769 - Adds the ability to use real Rust types for pallet aliases in the new Construct Runtime V2 macro
      • Note: Construct Runtime V2 + real Rust types implemented in this PR for StorageHub.
    • #4684 - Refactor of the parachain template to use Construct Runtime V2.
    • #3951 - pallet-assets-freezer, extension of pallet-assets that support freezes just like pallet-balances does.
      • Note: if we ever operate with tokens other than DOT, this is super important to know about, since we use freezes across most of our pallets.
    • #4765 - CheckWeight now accounts for the extrinsic length as proof size. This makes it so, when on_idle is called, the remaining weight parameter reflects this.
    • #4857 - Implements a Runtime API to help with XCM conversions from XCM’s Locations to runtime’s AccountIds. Also changes crate for XCM runtime APIs from xcm-fee-payment-runtime-api to xcm-runtime-apis.
      • Note: changes to crate name + new runtime APIs implementation done for StorageHub in this PR.
    • #4756 - Do not make pallet-nfts benchmarks signature-dependent.
      • Note: changes how the pallet needs to be configured to be benchmarked, so we will need to take care of this when benchmarking.
    • #3828 - Adds a RemoveStorage migration type, that allows runtimes to remove a storage item from a specific pallet when executing a migration.
  • Changelog for Node Operator:
    • #4685 - chain-spec-builder now supports codeSubstitutes with subcommand add-code-substitute. This allows users to provide a runtime that should be used from a given block onwards (until the next runtime upgrade)
      • Note: this allows bricked chains that are stalled due to runtime bugs to progress, but it needs an updated validation function on the relay chain that, up to the point when this release was made, was not there.
    • #4802 - Add health/readiness endpoint to the RPC server.
      • Note 1: the health/ endpoint was already there, but now it returns a few metrics that could be useful for testing: number of connected peers, an is_syncing variable that returns if the node is currently syncing, and a should_have_peers value which could be false for local chains or when running without discovery.
      • Note 2: the health/readiness endpoint checks if the node has at least one peer and is not currently doing major syncing, and if so returns HTTP 200 (it returns a 500 status code otherwise)
    • #4799 - Updates litep2p to v0.6.0
    • #5040 - Backport to update libp2p-websocket to v0.42.2 to fix panics
    • #5156 - Backport of #5113 to make sure new parachain blocks are always advancing their relay parents. This fix had to be made as, with elastic scaling implemented, the relay parent of a new candidate has to be not only more recent than the relay parent of the latest included candidate, but also more recent than the latest pending availability candidate.
  • Changelog for Runtime User:
    • #3820 - Remove deprecated calls from pallet-treasury: propose_spend, reject_proposal, approve_proposal
      • Note: flow for proposals has changed, good to know if we ever implement pallet-treasury

@TDemeco TDemeco requested review from ffarall and snowmead October 7, 2024 16:20
Copy link
Contributor

@ffarall ffarall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as usual!

runtime/src/configs/mod.rs Outdated Show resolved Hide resolved
xcm-simulator/src/storagehub/configs/mod.rs Outdated Show resolved Hide resolved
@@ -346,6 +348,13 @@ parameter_types! {
pub const MetadataDepositPerByte: Balance = 1 * UNIT;
}

impl pallet_parameters::Config for Runtime {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add pallet parameters just to match what was in the actual runtime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I want to make sure the runtime we use for the XCM simulator's tests is as close as possible to the actual runtime

@TDemeco TDemeco merged commit 93e424a into main Oct 7, 2024
21 checks passed
@TDemeco TDemeco deleted the update/polkadot-sdk-v1.14.0 branch October 7, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants