Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module select UI #662

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BenjaminAmos
Copy link
Contributor

Description

This pull request adds a module select screen, which allows the player to choose which modules to use when starting a new game.

image

Testing

  • Continue an existing game (to ensure that this still works).
  • Select the Play Game item in the main menu, followed by the New Game option. A Modules button should be visible in the bottom-left corner.
  • Select the Modules button and the modules screen should appear.
  • Create a few new games to test the following things:
    • When the warp module (or any other module, as applicable) is de-activated, you should not be able to select warp ships. Warp features, such as wormholes, should not appear in-game.
    • When the game is resumed, it should still only contain the modules selected upon its creation. No new modules should have be running, even if added after the save was created.

Known Issues

  • Console commands persist event after their module is removed. This is because the console is part of the application context, rather than the game context, which isn't unloaded until the application exits.
  • Modifications made to NUI screens by modules persist even after that module is removed.

Notes

This change updates WorldConfig to contain the system generators and feature generators that were used to generate the system. The world configuration was changed to be held centrally in SolGame and is now used as the authoritive source of truth for world generation.

Also updated some occurences of publicly-facing ArrayList<T> methods to the more generic List<T>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant