Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class Formula takes a python dict, which could cause problems due to mutability #1

Open
javaun opened this issue Mar 11, 2024 · 0 comments
Open

class Formula takes a python dict, which could cause problems due to mutability #1

javaun opened this issue Mar 11, 2024 · 0 comments

Comments

@javaun
Copy link
Collaborator

javaun commented Mar 11, 2024

If we keep load_formula we may want to put that inside the class as a static method. Right now Formula takes an argument for a dict -- "formula_json" -- and that is mutable and could introduce integrity issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javaun