Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering chat and burn not working #481

Open
JoaoZanetti opened this issue Nov 21, 2023 · 12 comments
Open

Rendering chat and burn not working #481

JoaoZanetti opened this issue Nov 21, 2023 · 12 comments

Comments

@JoaoZanetti
Copy link

The latest version does not render chat and burn to video (Frontend build: production - Frontend verbose: 2.4.1 (2023-11-19T23:24:21.447Z / )).

Error

image
As shown in this image, the process has three problems.

  1. the previous screenshot shows that the raw command returns "missing --output parameter". For some reason, placing this parameter as the last parameter returns this error, but the command will work (in parts) when placed after the --input parameter.
  2. after fixing the --output parameter location, twitch downloader cli will return a new exception "Unhandled exception. System.AggregateException: One or more errors occurred. (toguromaquiavel_2023-11-20T22_46_29Z_42047739465.chatdump is not a valid chat format)", the command needs another fix: replace XYZ.chatdump with XYZ_chat.json (I have both files; I don't know why)
  3. after manually issuing the fixed command, the twitch downloader cli did not generate the mask file (I don't know what a mask file is).

Configuration

image

Files

image

Output after using the fixed command

image

@MrBrax
Copy link
Owner

MrBrax commented Nov 21, 2023

seems like the chat format for twitchdownloader changed again and it's a nightmare to debug since there are no hints at all. maybe i have the patience to debug it again

@MrBrax
Copy link
Owner

MrBrax commented Nov 22, 2023

quite odd too that the downloaded chat works fine without any changes to render it for me

@JoaoZanetti
Copy link
Author

quite odd too that the downloaded chat works fine without any changes to render it for me

Maybe something related to the twitchdownloader version running in docker? I'm using the docker :master image

MrBrax added a commit that referenced this issue Nov 22, 2023
@MrBrax
Copy link
Owner

MrBrax commented Nov 22, 2023

possibly, i don't think it's that old though

@Nincodedo
Copy link
Contributor

Nincodedo commented Nov 29, 2023

I did some debugging and I think it has to do with how the background color value is being added. When I try to run the same rendering command the app generates...
/usr/local/bin/TwitchDownloaderCLI chatrender --temp-path /usr/local/share/twitchautomator/data/cache --ffmpeg-path /usr/bin/ffmpeg --input /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.json --chat-height 720 --chat-width 300 --framerate 60 --update-rate 0 --font Inter --font-size 12 --outline --background-color #00000000 --generate-mask --output /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.mp4

It fails. However, if I remove the # from the background-color, it works fine.

/usr/local/bin/TwitchDownloaderCLI chatrender --temp-path /usr/local/share/twitchautomator/data/cache --ffmpeg-path /usr/bin/ffmpeg --input /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.json --chat-height 720 --chat-width 300 --framerate 60 --update-rate 0 --font Inter --font-size 12 --outline --background-color 00000000 --generate-mask --output /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.mp4

I think it's "commenting out" part of the command.

@JoaoZanetti
Copy link
Author

I did some debugging and I think it has to do with how the background color value is being added. When I try to run the same rendering command the app generates... /usr/local/bin/TwitchDownloaderCLI chatrender --temp-path /usr/local/share/twitchautomator/data/cache --ffmpeg-path /usr/bin/ffmpeg --input /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.json --chat-height 720 --chat-width 300 --framerate 60 --update-rate 0 --font Inter --font-size 12 --outline --background-color #00000000 --generate-mask --output /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.mp4

It fails. However, if I remove the # from the background-color, it works fine.

/usr/local/bin/TwitchDownloaderCLI chatrender --temp-path /usr/local/share/twitchautomator/data/cache --ffmpeg-path /usr/bin/ffmpeg --input /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.json --chat-height 720 --chat-width 300 --framerate 60 --update-rate 0 --font Inter --font-size 12 --outline --background-color 00000000 --generate-mask --output /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.mp4

I think it's "commenting out" part of the command.

Same result here. Using double quotes in the background color fixes the problem.

@MrBrax
Copy link
Owner

MrBrax commented Dec 5, 2023

The hash part is really odd, considering the official help says to use them:

1701766614471

@Nincodedo
Copy link
Contributor

Right, but to use them with quotes around them.

@MrBrax
Copy link
Owner

MrBrax commented Dec 7, 2023

node's spawn automatically escapes sequences i'm pretty sure

@Nincodedo
Copy link
Contributor

Nincodedo commented Dec 7, 2023

I don't think it's working in this case. I copied the command that is sent to the logs. When running it as is with no changes...

/usr/local/bin/TwitchDownloaderCLI chatrender --temp-path /usr/local/share/twitchautomator/data/cache --ffmpeg-path /usr/bin/ffmpeg --input /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.json --chat-height 720 --chat-width 300 --framerate 60 --update-rate 0 --font Inter --font-size 12 --outline --background-color #00000000 --generate-mask --output /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.mp4

It fails with the error message "ERROR(S): Required option 'o, output' is missing.". But when I rerun it with added quotes around the background color...

/usr/local/bin/TwitchDownloaderCLI chatrender --temp-path /usr/local/share/twitchautomator/data/cache --ffmpeg-path /usr/bin/ffmpeg --input /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.json --chat-height 720 --chat-width 300 --framerate 60 --update-rate 0 --font Inter --font-size 12 --outline --background-color "#00000000" --generate-mask --output /usr/local/share/twitchautomator/data/storage/vods/undead_zeratul/2023-11-26/undead_zeratul_08_chat.mp4

It runs fine.

@MrBrax
Copy link
Owner

MrBrax commented Dec 7, 2023

but does the same issue appear when the server just runs the command?

@Nincodedo
Copy link
Contributor

I don't know the exact output since it doesn't display it in the logs, but it doesn't run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants