Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte bit depth support #32

Open
elaye opened this issue Apr 24, 2017 · 1 comment
Open

Byte bit depth support #32

elaye opened this issue Apr 24, 2017 · 1 comment

Comments

@elaye
Copy link
Contributor

elaye commented Apr 24, 2017

Hello, I'm interested in using the FFmpegWriter plugin with a byte bit depth but discovered that it wasn't supported.
By digging in the code I saw that it seemed to be because of colorspace conversion with OpenColorIO.
Is it a limitation of OpenColorIO or a use case you didn't want to support?

As a proof of concept I forked the repo added flags to disable OCIO and replaced the bit depth with bytes instead of floats everywhere.
Here is the relevant commit: elaye/openfx-io@1e12925
Ideally for my use case openfx-io could support both bit depths.
What would be your preferred approach to do that?

I'm happy to work on this but it would be good to have your direction.

@MrKepzie
Copy link
Owner

MrKepzie commented May 3, 2017

Hi, we actually never bothered to do something else than float because in Natron everything is 32bit floating point: we don't have any use case to have the Reader output directly a 8-bit image. If you remove the OCIO colourspace conversion as well as the premult/unpremult that may occur in some situations, you can then quiet easily support 8-bit rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants