Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up URLs from tracking #36

Open
Mte90 opened this issue Dec 2, 2021 · 2 comments
Open

Clean up URLs from tracking #36

Mte90 opened this issue Dec 2, 2021 · 2 comments

Comments

@Mte90
Copy link
Owner

Mte90 commented Dec 2, 2021

On this list https://github.com/mpchadwick/tracking-query-params-registry/blob/master/_data/params.csv there are a lot parameters that we can strip.
I don't know if it is the case to generate a json from that or pick just the most useful one, what do you think @PeterDaveHello?

@PeterDaveHello
Copy link
Collaborator

PeterDaveHello commented Dec 2, 2021

This reminds me that there are also: Cimbali/CleanLinks#63 and https://github.com/AdguardTeam/FiltersRegistry can be referenced, and currently the tracking clean up function here is not very maintainable(no offense), could refactor the code first and look for a better way to maintain the filter list.

As https://github.com/mpchadwick/tracking-query-params-registry/blob/master/_data/params.csv is csv format, is easy to convert it into a json format that js can easily consume, my idea is that we can use some external filter list like it, and then only maintain those not existed in all external filter list(before out pull requests to those repository are accepted, or for those not acceptable, if there are some) in this project.

@Mte90
Copy link
Owner Author

Mte90 commented Dec 2, 2021

function here is not very maintainable(no offense)

Of course it isn't I am not a good javascript developer :-)

only maintain those not existed in all external filter list

Seems a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants