-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work on certain link preview element anymore #39
Comments
I don't understand, what is the link preview area? |
Sorry not being clear enough. I mean the area to display link preview, like something you can see here when you put a url in the debug tool https://developers.facebook.com/tools/debug/, that Facebook will show preview of shared links. |
Yeah, I'm experiencing the same issue. The link cleaning isn't working anymore. This happens on posts of pages on the big preview created when sharing external links on a post. Previously, with the add-on installed, when clicking the preview link the browser would go straight to the final page without This happens even when one hovers over the preview and the link text at the bottom-left corner of the browser says the link is direct. It looks like Facebook adds some |
So with big preview do you mean the links when you are looking a photo on facebook at fullsize with the sidebar on the right? |
It stopped working for all preview links. For example: Please note that when hovering over the link you can see that it isn't facebooked yet. But when you click it it actually goes through |
I tested it and on my case I don't get that URL. |
This is happening to me on two different Windows 11 computers with Firefox 105 and Facebook Direct Links 1.3.6. |
It has been broken for me as well for a while. |
I tested right now and I get the screen with the facebook.com link and after the click is the direct one. Moving the mouse on the photo automatically change the link to the clean one |
If it's a direct link in the post, instead of the "preview" link, this extension is still working, maybe don't need to drop it? |
There isn't any direct link in the post, the link is generated by a AJAX request on hover in the box. in the |
@Mte90 I mean not those one mentioned in the subject of this issue, like this one: We can still copy the real link without problems, the link is https://beta.openai.com/ (from https://www.facebook.com/openai.research) |
What I'm trying to say if not all the features are dead, maybe you don't need to close the project and remove it from the addons store? |
Well it is most used for the big preview images with links, the cases with a URL in a fb post are very low. I mean I had to search a lot to find a post with just a link as now everyone prefer the preview link with the image as it is more useful for engagement and get a click. |
Not sure, but delete it will make sure we have no chance to bypass any of them, keeping it will at least let us to bypass some of them, even not so much. |
The problem is still not working for all the links but users expect that. So this require some changes on the description as example but I don't want to get opened various tickets asking why on preview links is not working. |
@Mte90 got your point. Maybe get pin this issue first? So people will see it first. |
Pinned the issue but I think that is not enough we need to something on the communications side for this. |
So I added a note in the Readme and in the Addons.Mozilla.org description about the Facebook changes. I think that there isn't else we can do about it sadly. |
Not sure if this idea would be too ideal, what about we try to send the request to the server to get the decrypted URL in the background? Need to test the latency though. |
Well facebook already do that decryption when you click on a link, how I didn't investigated but I don't think that is easy to understand the process. |
Look like there's problem to get the direct link from the link preview area.
I haven't digged it very deep yet, but use developer tool to take a look at the link preview area, found something interesting that the link will be changed to
https://l.facebook.com/l.php?u=
immediately when I clicked the right button, and changed back when the menu is closed or the mouse moved to some other places, not sure if it's done by Facebook though.The text was updated successfully, but these errors were encountered: