Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on certain link preview element anymore #39

Open
PeterDaveHello opened this issue Oct 6, 2022 · 22 comments
Open

Doesn't work on certain link preview element anymore #39

PeterDaveHello opened this issue Oct 6, 2022 · 22 comments

Comments

@PeterDaveHello
Copy link
Collaborator

Look like there's problem to get the direct link from the link preview area.

I haven't digged it very deep yet, but use developer tool to take a look at the link preview area, found something interesting that the link will be changed to https://l.facebook.com/l.php?u= immediately when I clicked the right button, and changed back when the menu is closed or the mouse moved to some other places, not sure if it's done by Facebook though.

@Mte90
Copy link
Owner

Mte90 commented Oct 6, 2022

I don't understand, what is the link preview area?

@PeterDaveHello
Copy link
Collaborator Author

Sorry not being clear enough. I mean the area to display link preview, like something you can see here when you put a url in the debug tool https://developers.facebook.com/tools/debug/, that Facebook will show preview of shared links.

@AntonioRedondo
Copy link

AntonioRedondo commented Oct 7, 2022

Yeah, I'm experiencing the same issue. The link cleaning isn't working anymore.

This happens on posts of pages on the big preview created when sharing external links on a post. Previously, with the add-on installed, when clicking the preview link the browser would go straight to the final page without https://l.facebook.com/l.php?u=. Now this cleaning isn't happening anymore and the nasty Facebook tracking redirection is active again, as if Facebook Direct Links wasn't installed.

This happens even when one hovers over the preview and the link text at the bottom-left corner of the browser says the link is direct. It looks like Facebook adds some onClick event that catches the link and adds the redirection URL.

@Mte90
Copy link
Owner

Mte90 commented Oct 7, 2022

So with big preview do you mean the links when you are looking a photo on facebook at fullsize with the sidebar on the right?
What links are not working in that view? without an example link is not easy to understand where it is happening the issue.

@AntonioRedondo
Copy link

It stopped working for all preview links. For example:
https://www.facebook.com/bbcnews/posts/pfbid0qFD6Bm8aazoGkDyjKQP1uVbXs6MUqQ92WRQtVY9tGqueMXV8HfYK2U3DuUSHboGPl

image

Please note that when hovering over the link you can see that it isn't facebooked yet. But when you click it it actually goes through https://l.facebook.com/l.php?u=.

@Mte90
Copy link
Owner

Mte90 commented Oct 7, 2022

I tested it and on my case I don't get that URL.

@AntonioRedondo
Copy link

This is happening to me on two different Windows 11 computers with Firefox 105 and Facebook Direct Links 1.3.6.

@rfc1036
Copy link

rfc1036 commented Mar 26, 2023

It has been broken for me as well for a while.

@Mte90
Copy link
Owner

Mte90 commented Mar 27, 2023

I tested right now and I get the screen with the facebook.com link and after the click is the direct one.

Moving the mouse on the photo automatically change the link to the clean one

@Mte90
Copy link
Owner

Mte90 commented Apr 2, 2023

I am investigating and seems that facebook just on hover change the URL with the one of the link.
Initially is a encrypted version like:
Screenshot_20230402_145314
On hover change the URL of the link with the direct one:
immagine

So we can't do anymore the trick of the extension as the URL was in the HTML page and extract it, now the URL is tracked server side and generated (probably for GDPR).
I will close the project and remove it from the addons store in the next days as it is clearly a feature that as browser extension we can't offer anymore as everything is crypted and parsed server side.

@PeterDaveHello
Copy link
Collaborator Author

If it's a direct link in the post, instead of the "preview" link, this extension is still working, maybe don't need to drop it?

@Mte90
Copy link
Owner

Mte90 commented Apr 2, 2023

There isn't any direct link in the post, the link is generated by a AJAX request on hover in the box. in the href="#" section above.

@PeterDaveHello
Copy link
Collaborator Author

@Mte90 I mean not those one mentioned in the subject of this issue, like this one:

image

We can still copy the real link without problems, the link is https://beta.openai.com/ (from https://www.facebook.com/openai.research)

@PeterDaveHello
Copy link
Collaborator Author

What I'm trying to say if not all the features are dead, maybe you don't need to close the project and remove it from the addons store?

@Mte90
Copy link
Owner

Mte90 commented Apr 2, 2023

Well it is most used for the big preview images with links, the cases with a URL in a fb post are very low.
Yes the extension in those cases remove the tracking stuff as it is still using the old way to generate those link and our trick works, but how much before they change also that?

I mean I had to search a lot to find a post with just a link as now everyone prefer the preview link with the image as it is more useful for engagement and get a click.

@PeterDaveHello
Copy link
Collaborator Author

Not sure, but delete it will make sure we have no chance to bypass any of them, keeping it will at least let us to bypass some of them, even not so much.

@Mte90
Copy link
Owner

Mte90 commented Apr 2, 2023

The problem is still not working for all the links but users expect that. So this require some changes on the description as example but I don't want to get opened various tickets asking why on preview links is not working.

@PeterDaveHello
Copy link
Collaborator Author

@Mte90 got your point. Maybe get pin this issue first? So people will see it first.

@Mte90 Mte90 pinned this issue Apr 2, 2023
@Mte90
Copy link
Owner

Mte90 commented Apr 2, 2023

Pinned the issue but I think that is not enough we need to something on the communications side for this.

@Mte90
Copy link
Owner

Mte90 commented Apr 4, 2023

So I added a note in the Readme and in the Addons.Mozilla.org description about the Facebook changes.

I think that there isn't else we can do about it sadly.

@PeterDaveHello
Copy link
Collaborator Author

Not sure if this idea would be too ideal, what about we try to send the request to the server to get the decrypted URL in the background? Need to test the latency though.

@Mte90
Copy link
Owner

Mte90 commented Apr 5, 2023

Well facebook already do that decryption when you click on a link, how I didn't investigated but I don't think that is easy to understand the process.
I just saw like 4/5 different server request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants