Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] ♻️ change routes for users: markadmin and markverified #167

Open
aayushchugh opened this issue Oct 28, 2022 · 3 comments
Open

[REFACTOR] ♻️ change routes for users: markadmin and markverified #167

aayushchugh opened this issue Oct 28, 2022 · 3 comments
Assignees
@BitOfAByte
Labels
refactor Refactor the code
Milestone
v1.0.0

Comments

@aayushchugh
Copy link
Member

Description

Currently we are using these routes

Mark user as admin --> PATCh /api/admin/users/markadmin/:id
Mark user as verified --> PATCH /api/admin/users/markverified/:id
Get all users --> GET /api/users
Update Username --> PATCh /api/users/:id
Delete user --> DELETE /api/admin/users/:id

we can change the routes of markadmin and markverified to follow conventions eg:-

Mark user as admin --> PATCH /api/admin/users/:id/markadmin
Mark user as verified --> PATCH /api/admin/users/:id/markverified

Anything else?

No response
@aayushchugh aayushchugh added the refactor Refactor the code label Oct 28, 2022
@aayushchugh aayushchugh added this to the v1.0.0 milestone Oct 28, 2022
@aayushchugh aayushchugh moved this to 🆕 New in Project Management Oct 28, 2022
@aayushchugh
Copy link
Member Author

aayushchugh commented Oct 28, 2022 •
edited
Loading

@MultiEmail/backend-developers I need feedback that if should we work on this or not

@BitOfAByte BitOfAByte self-assigned this Oct 28, 2022
@BitOfAByte
Copy link
Member

I can work on this today or tomorrow

@aayushchugh aayushchugh moved this from 🆕 New to 🚧 TODO in Project Management Oct 28, 2022
@is-it-ayush
Copy link
Member

Yeah! They look good. Go ahead with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BitOfAByte BitOfAByte

Labels
refactor Refactor the code
Projects
Project Management
Status: 🚧 TODO
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@is-it-ayush @BitOfAByte @aayushchugh